New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in Truffleruby #8602
Fix crash in Truffleruby #8602
Conversation
Cool. You'll need to tweak the changelog (see errors) Ideally, this would add a github action to test on truffleruby too. I think this might help. Same on |
6291f67
to
5de2189
Compare
@marcandre Github action added, but wow! It is slow. I've have reported the issue to the people in charge of Truffleruby. |
The slow tests issue is now tracked under oracle/truffleruby#2081 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I would squash the commits when merging though.
@marcandre Who can we ask to review & merge this? It would be useful to have a release of RuboCop including this fix as it blocks adding TruffleRuby in CI of other gems: |
@jaimerave Thanks for the PR! @eregon Thanks for the ping. Merged |
This adds a workaround for oracle/truffleruby#1484. With this change Rubocop no longer crashes when parsing files, an all the tests pass under Truffleruby 20.2.0 and head. Unfortunately, the tests are still too slow to add it to CI.
This change also improves performance a little bit:
With
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.