Fix Style/CaseLikeIf
not properly handling overriden equality methods
#8624
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a class overrides one of
#==
,#eql?
, orequal?
and the overridden method has no arguments, thenCaseLikeIf#find_target_in_equality_node
would error as it assumes there is at least one argument.Without the fix, the new spec returns an error:
I doubt you'll see much of
==
being overridden in the wild, but this particular case was found withequal?
. An object in my work's app takes in a bunch of data in its constructor andequal?
is overridden and used to verify some criterion on it.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.