Prevent an incorrect auto-correction for Style/CaseEquality cop
#8527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knu
reviewed
Aug 12, 2020
| @@ -58,7 +58,7 @@ def const?(node) | |||
| def replacement(lhs, rhs) | |||
| case lhs.type | |||
| when :regexp | |||
| "#{rhs.source} =~ #{lhs.source}" | |||
| "#{lhs.source}.match?(#{rhs.source})" | |||
There was a problem hiding this comment.
Before doing this, you need to check if the subsequent code does not refer to the match data (Regexp.last_match, $~, $1, etc.).
There was a problem hiding this comment.
Sure! I have a idea. Performance/Regexp cop detects Regexp.last_match, and etc. It is expected that a === b will be auto-corrected to a.match?(b) in future.
Reelated issue: rubocop/rubocop-performance#152
It currently doesn't support unsafe auto-correction, so it may be better to delegate it to Perfomance/Regexp cop.
koic
changed the title
Style/CaseEquality copStyle/CaseEquality cop
koic
force-pushed
the
fix_incorrect_autocorrect_for_style_case_equality
branch
from
8edcd50
to
9ef6bb7
Compare
bbatsov
approved these changes
Aug 17, 2020
Follow rubocop#8322 (comment) This PR prevents an incorrect auto-correction for `Style/CaseEquality` cop when comparing with `===` against a regular expression receiver. OTOH, the automatic correction from `a === b` to `a.match?(b)` needs to consider `Regexp.last_match?`, `$~`, `$1`, and etc. This correction is expected to be supported by `Performance/Regexp` cop. See: rubocop/rubocop-performance#152
koic
force-pushed
the
fix_incorrect_autocorrect_for_style_case_equality
branch
from
9ef6bb7
to
d771985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #8322 (comment)
This PR fixes an incorrect auto-correction for
Style/CaseEqualitycop when comparing with===against a regular expression receiver.This PR auto-correct
===withmatch?to keep compatibility of returning a boolean value.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.