Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cop idea: redudant self assignment #8451

Closed
marcandre opened this issue Aug 4, 2020 · 1 comment · Fixed by #8516
Closed

Cop idea: redudant self assignment #8451

marcandre opened this issue Aug 4, 2020 · 1 comment · Fixed by #8516

Comments

@marcandre
Copy link
Contributor

Since methods like Array#concat returns self:

# bad
args = args.concat(ary)
self.foo = foo.concat(ary)

# good
args.concat(foo) # or
args += foo
foo.concat(ary) # or
self.foo += ary

Noticed in our code

@marcandre
Copy link
Contributor Author

Note: I didn't check if we already have a similar cop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants