Allow cops to restrict callbacks on_send to specific method names only
#8365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
reviewed
Jul 19, 2020
|
ping @bbatsov |
|
ping @bbatsov Let me know if my ping frequency is too high too 😅 |
|
The frequency is fine, but I couldn't catch up with all the open PRs. I like the proposed change, but I think we need to document it better if we expect someone to actually use it. |
|
Cool. I'll document this and then merge. Thanks! |
marcandre
force-pushed
the
less_on_send
branch
4 times, most recently
from
14ea0c1
to
dd2574f
Compare
marcandre
force-pushed
the
less_on_send
branch
3 times, most recently
from
0968c72
to
c703039
Compare
marcandre
force-pushed
the
less_on_send
branch
from
c703039
to
e9173bb
Compare
marcandre
force-pushed
the
less_on_send
branch
from
e9173bb
to
7ca29a9
Compare
marcandre
force-pushed
the
less_on_send
branch
from
7ca29a9
to
a0f10f9
Compare
|
@marcandre I reworked the 200+ cops in Cookstyle to use this new functionality where we could. Since we're autocorrecting a DSL there's a lot of times we're just looking for a deprecated method call that needs to be replaced with a new one. Lots and lots of simple on_sends. My testing shows this sped things up about 16% against a large set of cookbooks. Nice work. |
|
16% is awesome, especially given the minimal trouble it is to specify it! 🎉 |
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Oct 11, 2020
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
8 tasks
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Oct 12, 2020
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Nov 10, 2020
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Nov 10, 2020
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
9 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Nov 11, 2020
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
6 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Mar 21, 2021
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Mar 21, 2021
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
This was referenced Mar 27, 2021
koic
added a commit
to koic/rubocop-rake
that referenced
this pull request
Aug 14, 2021
Follow up to rubocop/rubocop#8365. This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only.
koic
added a commit
to koic/rubocop-sequel
that referenced
this pull request
Aug 20, 2021
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only.
renawatson68
added a commit
to renawatson68/performance-develop-rubyonrails
that referenced
this pull request
Sep 23, 2022
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
koic
added a commit
to koic/rubocop-airbnb
that referenced
this pull request
Feb 27, 2023
Follow up rubocop/rubocop#8365. This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. https://docs.rubocop.org/rubocop/1.46/development.html#implementation
pariser
pushed a commit
to airbnb/ruby
that referenced
this pull request
Feb 27, 2023
Follow up rubocop/rubocop#8365. This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. https://docs.rubocop.org/rubocop/1.46/development.html#implementation
koic
added a commit
to koic/rubocop-graphql
that referenced
this pull request
Jun 22, 2023
Follow up rubocop/rubocop#8365. This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. https://docs.rubocop.org/rubocop/1.52/development.html#implementation `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90, so it bumps the required lowest runtime RuboCop dependency from 0.87 to 0.90. No runtime Ruby version incompatibilities between 0.87 and 0.90: https://docs.rubocop.org/rubocop/1.52/compatibility.html
koic
added a commit
to koic/rubocop-graphql
that referenced
this pull request
Jun 22, 2023
Follow up rubocop/rubocop#8365. This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. https://docs.rubocop.org/rubocop/1.52/development.html#implementation `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90, so it bumps the required lowest runtime RuboCop dependency from 0.87 to 0.90. No runtime Ruby version incompatibilities between 0.87 and 0.90: https://docs.rubocop.org/rubocop/1.52/compatibility.html
DmitryTsepelev
pushed a commit
to DmitryTsepelev/rubocop-graphql
that referenced
this pull request
Jun 22, 2023
Follow up rubocop/rubocop#8365. This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. https://docs.rubocop.org/rubocop/1.52/development.html#implementation `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90, so it bumps the required lowest runtime RuboCop dependency from 0.87 to 0.90. No runtime Ruby version incompatibilities between 0.87 and 0.90: https://docs.rubocop.org/rubocop/1.52/compatibility.html
MarttiCheng
added a commit
to MarttiCheng/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Follow rubocop/rubocop#8365 This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the recent optimizations for Cops seem to be to modify
on_sendto check early for thenode.method_nameagainst a specific list of names.This PR makes this pattern builtin so it is easy to do (just define
RESTRICT_ON_SEND = %i[foo bar baz]) and makes it even more efficient.Let's imagine 100 cops defining
on_sendthat could have such a restricted method list. On a run over 10kSendNode, if these cops are optimized with the first thing inon_sendbeingreturn if SOME_LIST.include?(node.method_name), there would still be 100*10k calls toon_send, and 100*10k calls toSet#include?(assuming thatSOME_LISTis aSet, as it should). With this PR, if the Cops are optimized with the right constant, then there would be only 10k hash lookups.cc/ @fatkodima