Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 1.21.0 to ~> 1.22.0 #837

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 29, 2021

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.22

New features

Bug fixes

  • #10110: Update Layout/DotPosition to be able to handle heredocs. (@​dvandersluis)
  • #10134: Update Style/MutableConstant to not consider multiline uninterpolated strings as unfrozen in ruby 3.0. (@​dvandersluis)
  • #10124: Fix Layout/RedundantLineBreak adding extra space within method chains. (@​dvandersluis)
  • #10118: Fix crash with Style/RedundantSort when the block doesn't only contain a single send node. (@​dvandersluis)
  • #10135: Fix Style/WordArray to exclude files in --auto-gen-config when percent style is given but brackets are required. (@​dvandersluis)
  • #10090: Fix a false negative for Style/ArgumentsForwarding when using only kwrest arg. (@​koic)
  • #10099: UpdateStyle/RedundantFreeze to stop considering ENV values as immutable. (@​byroot)
  • #10078: Fix Layout/LineLength reported length when ignoring directive comments. (@​dvandersluis)
  • #9934: Fix configuration loading to not raise an error for an obsolete ruby version that is subsequently overridden. (@​dvandersluis)
  • #10136: Update Lint/AssignmentInCondition to not consider assignments within blocks in conditions. (@​dvandersluis)
  • #9588: Fix causing a variable to be shadowed from outside the rescue block in the logic of Naming/RescuedExceptionsVariableName. (@​lilisako)
  • #10096: Fix Lint/AmbiguousOperatorPrecedence with and/or operators. (@​dvandersluis)
  • #10106: Fix Style/RedundantSelf for pattern matching. (@​dvandersluis)
  • #10066: Fix how MinDigits is calculated for Style/NumericLiterals when generating a configuration file. (@​dvandersluis)

Changes

Changelog

Sourced from rubocop's changelog.

1.22.0 (2021-09-29)

New features

Bug fixes

  • #10110: Update Layout/DotPosition to be able to handle heredocs. ([@​dvandersluis][])
  • #10134: Update Style/MutableConstant to not consider multiline uninterpolated strings as unfrozen in ruby 3.0. ([@​dvandersluis][])
  • #10124: Fix Layout/RedundantLineBreak adding extra space within method chains. ([@​dvandersluis][])
  • #10118: Fix crash with Style/RedundantSort when the block doesn't only contain a single send node. ([@​dvandersluis][])
  • #10135: Fix Style/WordArray to exclude files in --auto-gen-config when percent style is given but brackets are required. ([@​dvandersluis][])
  • #10090: Fix a false negative for Style/ArgumentsForwarding when using only kwrest arg. ([@​koic][])
  • #10099: UpdateStyle/RedundantFreeze to stop considering ENV values as immutable. ([@​byroot][])
  • #10078: Fix Layout/LineLength reported length when ignoring directive comments. ([@​dvandersluis][])
  • #9934: Fix configuration loading to not raise an error for an obsolete ruby version that is subsequently overridden. ([@​dvandersluis][])
  • #10136: Update Lint/AssignmentInCondition to not consider assignments within blocks in conditions. ([@​dvandersluis][])
  • #9588: Fix causing a variable to be shadowed from outside the rescue block in the logic of Naming/RescuedExceptionsVariableName. ([@​lilisako][])
  • #10096: Fix Lint/AmbiguousOperatorPrecedence with and/or operators. ([@​dvandersluis][])
  • #10106: Fix Style/RedundantSelf for pattern matching. ([@​dvandersluis][])
  • #10066: Fix how MinDigits is calculated for Style/NumericLiterals when generating a configuration file. ([@​dvandersluis][])

Changes

1.21.0 (2021-09-13)

New features

Bug fixes

  • #10067: Fix an error for Lint/NumberConversion when using nested number conversion methods. ([@​koic][])
  • #10054: Fix a false positive for Layout/SpaceAroundOperators when match operators between << and +=. ([@​koic][])
  • #10061: Fix a false positive for Style/RedundantSort when using size method in the block. ([@​koic][])
  • #10063: Fix a false positive for Layout/SingleLineBlockChain when method call chained on a new line after a single line block with trailing dot. ([@​koic][])

... (truncated)

Commits
  • 1bdcf65 Cut 1.22.0
  • 2c9664d Fix a changelog entry
  • a16bcb4 Update Changelog
  • 46d8867 [Fix #10135] Fix Style/WordArray to exclude files in --auto-gen-config wh...
  • e21a318 Merge pull request #10139 from dvandersluis/issue/10134
  • ed39d2b [Fix #10134] Update Style/MutableConstant to not consider multiline uninter...
  • 6dfc273 Merge pull request #10137 from dvandersluis/issue/10136
  • 45d8ed5 [Fix #10136] Update Lint/AssignmentInCondition to not consider assignments ...
  • 3a694f6 Update the message for Style/OptionalBooleanParameter.
  • a94b9fa Merge pull request #9961 from lilisako/fix-shadow-variable-in-rescued-excepti...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.21.0...v1.22.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 29, 2021
@olleolleolle
Copy link
Contributor

olleolleolle commented Sep 30, 2021

https://github.com/cucumber/aruba/pull/837/checks?check_run_id=3748310818#step:5:7

Running RuboCop...
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/fixtures/cli-app/lib/cli/app.rb:3:60.
To see the complete backtrace run rubocop -d.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/fixtures/cli-app/spec/spec_helper.rb:8:17.
To see the complete backtrace run rubocop -d.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/lib/aruba/platforms/unix_platform.rb:102:65.
To see the complete backtrace run rubocop -d.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/spec/spec_helper.rb:10:65.
To see the complete backtrace run rubocop -d.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/spec/spec_helper.rb:11:68.
To see the complete backtrace run rubocop -d.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/fixtures/cli-app/lib/cli/app.rb:3:60.
To see the complete backtrace run rubocop -d.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/fixtures/cli-app/spec/spec_helper.rb:8:17.
To see the complete backtrace run rubocop -d.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/lib/aruba/platforms/unix_platform.rb:102:65.
To see the complete backtrace run rubocop -d.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/spec/spec_helper.rb:10:65.
Inspecting 177 files
To see the complete backtrace run rubocop -d.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/spec/spec_helper.rb:11:68.
To see the complete backtrace run rubocop -d.

5 errors occurred:
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/fixtures/cli-app/lib/cli/app.rb:3:60.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/fixtures/cli-app/spec/spec_helper.rb:8:17.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/lib/aruba/platforms/unix_platform.rb:102:65.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/spec/spec_helper.rb:10:65.
An error occurred while Lint/RequireRelativeSelfPath cop was inspecting /home/runner/work/aruba/aruba/spec/spec_helper.rb:11:68.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/rubocop/rubocop/issues

@koic
Copy link
Member

koic commented Sep 30, 2021

That error has been resolved by rubocop/rubocop#10146. It will be available in the next release. Thank you for your patience.

@olleolleolle
Copy link
Contributor

@koic Happy to hear good news! We'll wait, we have all the time in the world.

Thanks for caring about Aruba!

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 4, 2021

Superseded by #839.

@dependabot dependabot bot closed this Oct 4, 2021
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-tw-1.22.0 branch October 4, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants