Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Layout/LineLength reported length when ignoring directive comments #10078

Merged

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Sep 13, 2021

If IgnoreCopDirectives is enabled, the directive comment is not included in the calculation, but it is included in the count that is shown in the offense. This change makes it not be included there either.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…nts.

If `IgnoreCopDirectives` is enabled, the directive comment is not included in the calculation, but it is included in the count that is shown in the offense. This change make it not be included there either.
@koic koic merged commit 35d3540 into rubocop:master Sep 14, 2021
@koic
Copy link
Member

koic commented Sep 14, 2021

Thanks!

@dvandersluis dvandersluis deleted the layout/line-length-without-directive branch September 14, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants