Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Style/NumberedParametersLimit cop #10111

Merged

Conversation

dvandersluis
Copy link
Member

Follows #10100 (comment).

@bbatsov: I think this cop should also have some limit on the number of numbered params in a block (regardless of the length of the block), as things can get very dicey with 2+ numbered params IMO. This, however, would imply an "allow" style as well, so perhaps a separate cop is in order down the road (e.g. NumberOfNumberedParams or something like this).

This adds a new Style/ExcessiveNumberedParameters cop that allows a maximum number of numbered params in a single block. The Max is configurable.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

config/default.yml Outdated Show resolved Hide resolved
@dvandersluis dvandersluis changed the title Add new Style/ExcessiveNumberedParameters cop. Add new Style/NumberedParametersLimit cop Sep 23, 2021
config/default.yml Outdated Show resolved Hide resolved
@dvandersluis
Copy link
Member Author

The default value for Max has been changed to 1 now.

@dvandersluis
Copy link
Member Author

@Drenmi @bbatsov @koic any other changes needed here?

@bbatsov bbatsov merged commit 9815b39 into rubocop:master Sep 27, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 27, 2021

Nope, looks good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants