[Fix #10136] Update Lint/AssignmentInCondition to not consider assignments within blocks in conditions
#10137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er assignments within blocks in conditions.
|
Thanks! |
jonas054
added a commit
to jonas054/rubocop
that referenced
this pull request
Mar 23, 2024
In rubocop#10137 a fix was made that makes the condition asgn_node.send_type? && !asgn_node.assignment_method? unnecessary in AssignmentInCondition#skip_children?(). The spec example 'accepts = in a block followed by method call' that was added to regression test this part of the code still passes if I remove the condition.
bbatsov
pushed a commit
that referenced
this pull request
Mar 25, 2024
In #10137 a fix was made that makes the condition asgn_node.send_type? && !asgn_node.assignment_method? unnecessary in AssignmentInCondition#skip_children?(). The spec example 'accepts = in a block followed by method call' that was added to regression test this part of the code still passes if I remove the condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignments within a block are not relevant to this cop because they don't affect the same scope.
Fixes #10136.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.