Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint/BooleanSymbol should be marked as SafeAutoCorrect: false rather than Safe: false #10088

Merged
merged 1 commit into from Sep 16, 2021

Conversation

dvandersluis
Copy link
Member

Although the correction is unsafe, the cop itself will not find false positives.

config/default.yml Outdated Show resolved Hide resolved
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 16, 2021

This deserves a changelog entry IMO.

…n `Safe: false`.

Although the correction is unsafe, the cop itself will not find false positives.
@koic koic merged commit 4b0aad3 into rubocop:master Sep 16, 2021
@koic
Copy link
Member

koic commented Sep 16, 2021

Good catch! 👍

@dvandersluis dvandersluis deleted the boolean-symbol branch September 27, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants