[Fix #9588] Fix causing a variable to be shadowed from outside the rescue block #9961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Aug 6, 2021
koic
reviewed
Aug 13, 2021
| @@ -75,6 +75,9 @@ def on_resbody(node) | |||
| preferred_name = preferred_name(offending_name) | |||
| return if preferred_name.to_sym == offending_name | |||
|
|
|||
| # check variable shadowing for exception variable | |||
| return if check_shadowed_variable_name(node) | |||
There was a problem hiding this comment.
Can you update the caller name as well?
Suggested change
| return if check_shadowed_variable_name(node) | |
| return if shadowed_variable_name?(node) |
koic
reviewed
Aug 13, 2021
| node.each_descendant(:lvar) do |n| | ||
| return true if n.children.first.to_s == preferred_name(n) | ||
| end | ||
| false |
There was a problem hiding this comment.
It seems that it can be simplified by using any?.
def shadowed_variable_name?(node)
- node.each_descendant(:lvar) do |n|
- return true if n.children.first.to_s == preferred_name(n)
- end
- false
+ node.each_descendant(:lvar).any? { |n| n.children.first.to_s == preferred_name(n) }
end
|
@lilisako ping! |
|
@lilisako Can you make this CI successful? |
|
Looks like you need to rebase your branch. |
|
Sorry for getting back to you late. I'll do it within 5-6 hours! When it's done I'm doing to mention you. Thanks! |
…scue block This PR fixes causing a variable to be shadowed from outside the rescue block from Naming/RescuedExceptionsVariableName
|
@koic @dvandersluis |
|
Thanks! |
lilisako
deleted the
fix-shadow-variable-in-rescued-exceptions-variable-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9588
Fix causing a variable to be shadowed from outside the rescue block.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.