chore(deps-dev): update rector/rector requirement from 0.13.8 to 0.13.9

[dependabot]

Updates the requirements on rector/rector to permit the latest version.

Release notes

Sourced from rector/rector's releases.

Released Rector 0.13.9

New Features 🎉

• [CodingStyle] Add StaticArrowFunctionRector (#2657)
• [CodingStyle] Add StaticClosureRector (#2658)
• [Php80] Add implements interface support on single file on AddParamBasedOnParentClassMethodRector (#2660
• [PHP 8.1] Extend MyCLabsMethodCallToEnumConstRector with getValue() and static call (#2695)
• [PHP 8.1] Keep use stmts in MyCLabsClassToEnumRector enum (#2696)
• Add AddReturnTypeDeclarationBasedOnParentClassMethodRector (#2666), Thanks @​MartinMystikJonas!
• [DX] Add input validation for method, property and function name to avoid invalid output ast (#2668)
• Improve namespace names validation (#2670)

Bugfixes 🐛

• [DeadCode] Skip global and static variable on RemoveJustVariableAssignRector (#2641)
• [DeadCode] Skip global and static variable on ReturnEarlyIfVariableRector (#2642)
• [StrictTypes] Add MethodCall/StaticCall to ExclusiveNativeCallLikeReturnMatcher (#2646)
• [TypeDeclaration] Add assigned new to variable in ReturnTypeFromReturnNewRector (#2647)
• DependencyClassMethodDecorator: Prevent duplication of arguments (#2643), Thanks @​jtojnar!
• [TypeDeclaration] Skip Type modified between Assign and Return_ on ReturnTypeFromReturnNewRector (#2650)
• [TypeDeclaration] Skip modififed type between assign and return on ReturnTypeFromStrictNewArrayRector (#2651)
• [Php74] Skip TypedPropertyRector on final class by @​final docblock (#2654)
• [DeadCode] Handle crash on indirect parent BinaryOp on RemoveDuplicatedInstanceOfRector (#2656), #7293
• [TypeDeclaration] Skip property exists in parent on TypedPropertyFromStrictConstructorRector (#2659)
• Fix test to only resolve to known classes (#2663), Thanks @​dritter!
• Fix getter method property substitution when the readable types don't match. (#2667), Thanks @​mad-briller!
• [CodeQuality] Handle crash attribute used on trait on CallableThisArrayToAnonymousFunctionRector (#2675)
• Attempt to fix incorrect doctrine table attribute values on php 8.1 (#2699), Thanks @​acrobat!
• [Transform] Handle crash string in EnumCase on StringToClassConstantRector (#2680)
• Fix InlineArrayReturnAssignRector and ChangeReadOnlyPropertyWithDefaultValueToConstantRector collision (#2701)

Removed 🗑️

• move ReturnTypeFromStrictTypedCallRector to enterprise (#2683)
• [DX] Cleanup, Remove RepeatedLiteralToClassConstantRector, as very narrow use case; use rather phpstan + Remove ChangeLocalPropertyToVariableRector, as buggy and unreliable; better use PHPStan (#2686)
• Remove UnwrapFutureCompatibleIfFunctionExistsRector as very niche and specific (#2688)
• [CodingStyle] Deprecate PHPStormVarAnnotationRector, rather tokens responsibility (#2677)

Commits

• d6319ec Rector 0.13.9
• 66a5285 Updated Rector to commit cdf7bf581c6a417cfc8fc2b256597f30165d061f
• d21608a Updated Rector to commit c4d6f19b4d6386758b1f7aee3f1a9d4e41b59b42
• 1d65784 Updated Rector to commit 1836de97836c78ae4c85c1fdce3664688fb1011f
• e383186 Updated Rector to commit 764416672a588c4bd80084a853973773f9835690
• be073d8 Updated Rector to commit 1000cd51c57f7672d7e87c312cada4150bd98dd6
• 254b108 Updated Rector to commit ff524c546b9bc82cd5f1dcf3d0870d40d2cd64df
• 2f66cf1 Updated Rector to commit 07ab6051dff0262c2ee6ea060056bf9e56186ada
• 951e340 Updated Rector to commit 49a8343323c6cc5c40e1ca0ef4b3e6c418848ea7
• cebbc83 Updated Rector to commit 963c48c32a154f0045adde8793492afb0bf3caf2
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[MGatner]

Looks like new version of Rector isn't respecting dynamicConstantNames. @samsonasik

[samsonasik]

$rectorConfig->phpstanConfig() may be needed, I will check.

[samsonasik]

Fixed 🎉

[samsonasik]

Registering phsptan config seems make RemoveAlwaysTrueIfConditionRector only lookup phpstan @var which can be invalid on property, eg, on MemcachedHandler

@@ @@
         if ($this->memcached instanceof Memcached) {
             return $this->memcached->set($key, $value, $ttl);
         }
-
-        if ($this->memcached instanceof Memcache) {
-            return $this->memcached->set($key, $value, 0, $ttl);
-        }
-
-        return false;
+        return $this->memcached->set($key, $value, 0, $ttl);

let's skip for now.

[samsonasik]

@MGatner it seems working ok now, I will check if I can verify to skip property by @var check on RemoveAlwaysTrueIfConditionRector and crash on RemoveDeadZeroAndOneOperationRector

[samsonasik]

RemoveDeadZeroAndOneOperationRector bug PR fix rectorphp/rector-src#2714

[kenjis]

Thanks, @samsonasik

[MGatner]

Thanks @samsonasik! Your Rector expertise is always appreciated.

Would you review the rector.php template in CodeIgniter DevKit and recommend any parallel changes (if relevant)?

[samsonasik]

@MGatner I will try.