Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Cleanup, Remove RepeatedLiteralToClassConstantRector, as very narrow use case; use rather phpstan + Remove ChangeLocalPropertyToVariableRector, as buggy and unreliable; better use PHPStan #2686

Merged
merged 8 commits into from Jul 19, 2022
Merged

[DX] Cleanup, Remove RepeatedLiteralToClassConstantRector, as very narrow use case; use rather phpstan + Remove ChangeLocalPropertyToVariableRector, as buggy and unreliable; better use PHPStan #2686

merged 8 commits into from Jul 19, 2022

Conversation

TomasVotruba
Copy link
Member

  • indent
  • [DX] Remove RepeatedLiteralToClassConstantRector, as very narrow use case; use rather phpstan
  • [DX] Remove ChangeLocalPropertyToVariableRector, as buggy and unreliable; better use PHPStan
  • typo
  • enable rules

@TomasVotruba TomasVotruba changed the title tv cleanup 3 [DX] Cleanup, Remove RepeatedLiteralToClassConstantRector, as very narrow use case; use rather phpstan + Remove ChangeLocalPropertyToVariableRector, as buggy and unreliable; better use PHPStan Jul 19, 2022
@TomasVotruba TomasVotruba enabled auto-merge (squash) July 19, 2022 21:03
@TomasVotruba TomasVotruba merged commit b492d20 into main Jul 19, 2022
@TomasVotruba TomasVotruba deleted the tv-cleanup-3 branch July 19, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TomasVotruba @actions-user