Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly incorrect example for ClassPropertyAssignToConstructorPromotionRector #7293

Closed
yevsid opened this issue Jul 13, 2022 · 3 comments
Closed

Comments

@yevsid
Copy link

yevsid commented Jul 13, 2022

I came across ClassPropertyAssignToConstructorPromotionRector, and an example shows changed public property to private promoted.

Is it a mistake in documentation, or it really works like this?

@TomasVotruba
Copy link
Member

Thanks for checking. Seems like docs issue :) could you update it in the rule itself?

@samsonasik
Copy link
Member

@samsonasik
Copy link
Member

Fixed at rectorphp/rector-src#2711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants