Attempt to fix incorrect doctrine table attribute values on php 8.1

[acrobat]

Reverted some changes of #1850 as they resulted in incorrect doctrine Table attribute values on php 8.1 (indexes and uniqueConstraints can't be initialized inline) + some extra needed fixes

Fixes rectorphp/rector#7163 and partial fix of rectorphp/rector-doctrine#116 (point 1 and 2)

I've updated the failing test of rector-doctrine in rectorphp/rector-doctrine#118

[TomasVotruba]

Thank you for the PR. The rector-doctrine now passed well 👍

One Rector run is still failing though. Could you fix it?

[acrobat]

Well I tried to debug and fix it but I don't understand it 😅 The bin/rector process packages command fails when I removed the __constructor body of \Rector\PhpAttribute\NodeFactory\PhpAttributeGroupFactory 🤔 Do you have an idea @TomasVotruba?

[TomasVotruba]

Have you tried to dump the line it refers?

"Rector\Core\PhpParser\Node\Value\ValueResolver::resolveClassConstFetch()":264"        

Then I'd try to narrow down what file or code is causing it.

bin/rector p packages/Exact/File.php

Then dump the node before last crash and you'll see the broken code snippet.

[acrobat]

Debug info

That's indeed what I did but I don't understand why it fails.

bin/rector process packages/PhpAttribute/NodeFactory/PhpAttributeGroupFactory.php

The error is throw in this part of the code

rector-src/src/PhpParser/Node/Value/ValueResolver.php

Lines 248 to 268 in ff524c5

	private function resolveClassConstFetch(ClassConstFetch $classConstFetch)
	{
	$class = $this->nodeNameResolver->getName($classConstFetch->class);
	$constant = $this->nodeNameResolver->getName($classConstFetch->name);
	if ($class === null) {
	throw new ShouldNotHappenException();
	}
	if ($constant === null) {
	throw new ShouldNotHappenException();
	}
	if ($class === ObjectReference::SELF) {
	$classLike = $this->betterNodeFinder->findParentType($classConstFetch, ClassLike::class);
	if (! $classLike instanceof ClassLike) {
	throw new ShouldNotHappenException();
	}
	$class = (string) $this->nodeNameResolver->getName($classLike);
	}

I've dumped the resolved $class and. $classConstant values on line 264 and these are

string(4) "self"
string(21) "UNWRAPPED_ANNOTATIONS"

And therefor the $classLike is null and the exception is thrown. I don't understand as there is no constant UNWRAPPED_ANNOTATIONS, only a property $unwrappedAnnotations. What can you dump more to maybe get more specific info on where it goes wrong in \Rector\PhpAttribute\NodeFactory\PhpAttributeGroupFactory?

Or does rector try to convert the private property to a constant as it is not used anymore to assign a value? But it fails somehow

EDIT: Changing it a constant instead of a property does indeed seem to fix it!

[TomasVotruba]

Great job 👍

Could you push the feature and fix commits separately? I'm curious what is the fix for next time this happens :)

[acrobat]

Done!

[TomasVotruba]

Thanks 👍

it's interesting, that should not be a problem for Rector.
Both version are valid and should be resolved witout fail.

I'll check this one later and merge this along with it, so I don't forget the bug in another rule 👍 Thank you

[TomasVotruba]

The solution is on the way 😀 👍
See #2781