Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeDeclaration] Skip modified type between assign and return on ReturnTypeFromStrictNewArrayRector #2651

Merged
merged 2 commits into from Jul 10, 2022

Conversation

samsonasik
Copy link
Member

Same with #2650, the following code should be skipped:

final class SkipModifiedTypeBetweenAssignAndReturn
{
    public function run()
    {
        $values = [];

        $this->settings($values);

        return $values;
    }

    private function settings(&$values)
    {
        $values = 1;
    }
}

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 5debc09 into main Jul 10, 2022
@TomasVotruba TomasVotruba deleted the skip-mod branch July 10, 2022 17:42
@TomasVotruba
Copy link
Member

Thank you 👍

@samsonasik samsonasik changed the title [TypeDeclaration] Skip modififed type between assign and return on ReturnTypeFromStrictNewArrayRector [TypeDeclaration] Skip modified type between assign and return on ReturnTypeFromStrictNewArrayRector Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants