[TypeDeclaration] Skip Type modified between Assign and Return_ on ReturnTypeFromReturnNewRector

[samsonasik]

The following code should be skipped:

final class SkipTypeModifiedBetweenAssignAndReturn
{
    public function action()
    {
        $response = new SomeResponse();

        $this->verify($response);

        return $response;
    }

    private function verify(SomeResponse &$someResponse): void
    {
        if (is_cli()) {
            $someResponse = new CLIResponse();
        }
    }
}

[samsonasik]

Fixed 🎉

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[samsonasik]

I updated to verify with type change on next Stmt on pass by reference use case.

[samsonasik]

I found another use case to be skipped:

final class SkipTypeModifiedBetweenAssignAndReturnWithIf
{
    public function action()
    {
        $response = new SomeResponse();

        if (is_cli()) {
            $response = new CLIResponse();
        }

        return $response;
    }
}

[samsonasik]

Fixed 🎉

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[TomasVotruba]

Thank you 👍