Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated and cleaned defluent config #2683

Closed
wants to merge 1 commit into from

Conversation

TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba changed the title remove defluent Remove deprecated and cleaned defluent config Jul 19, 2022
@TomasVotruba
Copy link
Member Author

TomasVotruba commented Jul 19, 2022

@samsonasik Hey, could you handle the new duplicated variable name rule? :) The one failing in PHPStan CI.

Basically it united variables names, to avoid possible casing bug on 2 similar but different named variables. The fix could look like:

-$realvalue = 100;
+$realValue = 100;

 $realValue = 500;

Basically all variable must have the same name casing.

@TomasVotruba
Copy link
Member Author

Sets were resolved in another PR

@TomasVotruba TomasVotruba deleted the tv-narrow-arrays branch July 19, 2022 18:22
@samsonasik
Copy link
Member

@TomasVotruba is the rule is deprecated-packages/symplify#4230 ?

@TomasVotruba
Copy link
Member Author

Yes 👍 and duplciated constant regexes.

Basically to uncomment these 2 lines:

rector-src/phpstan.neon

Lines 712 to 714 in c3e31f0

# @todo resolve later
- '#Lowered variable "(.*?)" is used in various\-cased names\: "(.*?)", unite it to one#'
- '#The "(.*?)" constant contains duplicated regex "(.*?)"\. Instead of duplicated regexes, extract domain regexes together to save maintenance#'

@samsonasik
Copy link
Member

I see

- '#Lowered variable "(.*?)" is used in various\-cased names\: "(.*?)", unite it to one#'

@samsonasik
Copy link
Member

It seems various cases actually valid, eg, the following:

    private function storeConfigurationDataHash(string $filePath, string $configurationHash): void
    {
        $key = CacheKey::CONFIGURATION_HASH_KEY . '_' . Strings::webalize($filePath);
        $this->invalidateCacheIfConfigurationChanged($key, $configurationHash);

        $this->cache->save($key, CacheKey::CONFIGURATION_HASH_KEY, $configurationHash);
    }

@samsonasik
Copy link
Member

Ok, it seems vaiable naming is check all places, not only current file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants