Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript 4.5 upgrade, loads of new linting #1351

Merged
merged 30 commits into from Dec 23, 2021
Merged

Typescript 4.5 upgrade, loads of new linting #1351

merged 30 commits into from Dec 23, 2021

Conversation

Stephen-ONeil
Copy link
Contributor

@Stephen-ONeil Stephen-ONeil commented Dec 22, 2021 •
edited

#1350 re-pushed with CI-friendly branch name 🙄

Closes #1213
Closes #1068

TODO:

  • upgrade TS (and Prettier)
    • and eslint
      • ... and fix no-unused-vars rule, tons of linting for that
      • while I'm at it, better project wide linting script, lint everywhere
      • maybe a side-job in CI to check global linting, right now only client src code is actually regularly checked by CI
        • bonus, extended this job to check prettier and types as well, removed prettier from the local pre-push hook
  • Identify mixed JS/type imports, add type flags (see here)

This was referenced Dec 22, 2021
Closed
Closed
@Stephen-ONeil Stephen-ONeil changed the title Typescript 4.5 upgrade Typescript 4.5 upgrade, loads of new linting Dec 22, 2021
@Stephen-ONeil
TypeScript 4.5 and Prettier 2.5 (for TS 4.5 syntax support
2382ac6
@Stephen-ONeil
Drop deprectaed prettier rule jsxBracketSameLine
41e6317
@Stephen-ONeil
Update eslint from 7 to 8, corresponding versions of @typescript-eslint…
405187d 
… for TS 4.5 support
@Stephen-ONeil
Rename root package.json prettier scripts, add eslint scripts
ddfc0d2
@Stephen-ONeil
Add a prettier write call post eslint:fix, closes #1213
2675226
@Stephen-ONeil
Change prettier:write log level to warn, default logging is overly ve…
8bbcf63 
…rbose
@Stephen-ONeil
Use consistent, desired, configuration for no-unused-vars in both js …
ad8eb07 
…and ts (warn, but ignore arguments starting with an _)
@Stephen-ONeil
Centralize eslint ignore rules at top level, like we have with the pr…
682d119 
…ettier ignores. Simplifies running project-wide linting
@Stephen-ONeil
Misc linting
ac948b8
@Stephen-ONeil
Sort out linting in root scripts, fix some lint errors there and in f…
8bac211 
…orm_backend
@Stephen-ONeil
Lint instance of no-use-before-define in server code
39a8d39
@Stephen-ONeil
Add stand alone repo-wide lint job to CI
c8400b7
@Stephen-ONeil
Configure repo wide eslint command to cache
673c70e
@Stephen-ONeil
Make use of eslint caches in CI lint job
85f922d
@Stephen-ONeil
Lint no-unused-vars in form_backend and server
93cefc3
@Stephen-ONeil
Extract CI install steps to fragments, to make sure cache keys are co…
eb0261f 
…nsistently used. Add all installs to project-wide lint job to make sure necessary eslint plugins are all installed (might not be worth having this centralized lint job afterall, hmm)
@Stephen-ONeil
Ah, CircleCI has a "commands" syntax for reusable blocks of steps, th…
5fcd131 
…at's good because whatever I was trying with yaml fragments wasn't going to work, ha
@Stephen-ONeil
Set max warnings to 0 for repo wide eslint scan, mainly so CI gets th…
8fb128b 
…e non 0 exit status on warnings as well as errors too
@Stephen-ONeil
Fix rest arg error introduced by removing an unused var in the server…
6ca94c3 
… people popuate code
@Stephen-ONeil
Set ignoreRestSiblings: true in no-unused-vars lint rule, a bit of a …
7605694 
…gotcha when left on the default false (and trying to fix a large numer of these quickly, ha)
@Stephen-ONeil
Add TODO on CI lint job, consider expanding to check prettier and typ…
f73ee5d 
…ing as well
@Stephen-ONeil
Tangent, drop some old stories modules I missed
ec22b92
@Stephen-ONeil
Lint for no-unused vars in client (everywhere outside of panels and c…
52a65b8 
…omponents
@Stephen-ONeil
Lint the rest of the client no-unused-vars
9b851dc
@Stephen-ONeil
Enable @typescript-eslint/consistent-type-imports, auto-fix it
ab836e5
Steph-Rancourt
Steph-Rancourt approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@Steph-Rancourt Steph-Rancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, mostly just a CI job change and some linting (didn't look at all those files too too closely)

@Stephen-ONeil Stephen-ONeil merged commit 4275407 into master Dec 23, 2021
@Stephen-ONeil Stephen-ONeil deleted the typescript-four-point-five branch December 23, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steph-Rancourt Steph-Rancourt Steph-Rancourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add combined eslint fix + prettier write script Have a CI step that checks that webpack output is clean
2 participants
@Stephen-ONeil @Steph-Rancourt