Typescript 4.5 upgrade, loads of new linting

.circleci/config.yml

@@ -1,44 +1,112 @@
+version: 2.1
+
 dockerhub_auth: &dockerhub_auth
   auth:
     username: $DOCKERHUB_USERNAME
     password: $DOCKERHUB_PASSWORD
 
-# yaml fragment for deploy filters
 deploy_filter: &deploy_filter
   filters:
     branches:
       ignore:
         - /__.*/
 
-version: 2.1
-
-jobs:
-  test_form_backend:
-    docker:
-      - image: eaadtbs/ib-ci-build:3.0
-        <<: *dockerhub_auth
-    working_directory: "~/InfoBase"
+commands:
+  top_level_install:
     steps:
-      - checkout:
-          path: "~/InfoBase"
       - restore_cache:
           keys:
-            - form-backend-dependencies-{{ checksum "form_backend/package-lock.json" }}-v2
             - top-level-dependencies-{{ checksum "package-lock.json" }}-v2
       - run:
           command: |
-            [ -e "form_backend/node_modules" ] || (cd form_backend && npm ci)
+            [ -e "node_modules" ] || npm ci
+      - save_cache:
+          key: top-level-dependencies-{{ checksum "package-lock.json" }}-v2
+          paths:
+            - node_modules
+  form_backend_install:
+    steps:
+      - restore_cache:
+          keys:
+            - form-backend-dependencies-{{ checksum "form_backend/package-lock.json" }}-v2
       - run:
           command: |
-            [ -e "node_modules" ] || npm ci
+            [ -e "form_backend/node_modules" ] || (cd form_backend && npm ci)
       - save_cache:
           key: form-backend-dependencies-{{ checksum "form_backend/package-lock.json" }}-v2
           paths:
             - form_backend/node_modules
+  server_install:
+    steps:
+      - restore_cache:
+          keys:
+            - server-dependencies-{{ checksum "server/package-lock.json" }}-v2
+      - run:
+          command: |
+            [ -e "server/node_modules" ] || (cd server && npm ci)
       - save_cache:
-          key: top-level-dependencies-{{ checksum "package-lock.json" }}-v2
+          key: server-dependencies-{{ checksum "server/package-lock.json" }}-v2
           paths:
-            - node_modules
+            - server/node_modules
+  client_install:
+    steps:
+      # need to bust the client package cache on patch changes in addition to package-lock changes
+      - run: cksum ./client/patches/* > client-patch-checksums
+      - restore_cache:
+          keys:
+            - client-dependencies-{{ checksum "client/package-lock.json" }}-{{ checksum "client-patch-checksums" }}-v2
+      - run:
+          command: |
+            [ -e "client/node_modules" ] || (cd client && npm ci)
+      - save_cache:
+          key: client-dependencies-{{ checksum "client/package-lock.json" }}-{{ checksum "client-patch-checksums" }}-v2
+          paths:
+            - client/node_modules
+            - client/.cache/Cypress # path set by CYPRESS_CACHE_FOLDER env var
+
+jobs:
+  static_analysis:
+    docker:
+      - image: eaadtbs/ib-ci-build:3.0
+        <<: *dockerhub_auth
+    working_directory: "~/InfoBase"
+    steps:
+      - checkout:
+          path: "~/InfoBase"
+
+      - top_level_install
+      - form_backend_install
+      - server_install
+      - client_install
+
+      - restore_cache:
+          keys:
+            - repo-wide-lint-cache-{{ .Branch }}
+            - repo-wide-lint-cache-master
+      - run:
+          command: npm run eslint
+      - save_cache:
+          key: repo-wide-lint-cache-{{ .Branch }}
+          paths:
+            - .eslintcache
+
+      - run:
+          command: npm run prettier
+
+      - run:
+          command: cd client && npx tsc --noEmit
+
+  test_form_backend:
+    docker:
+      - image: eaadtbs/ib-ci-build:3.0
+        <<: *dockerhub_auth
+    working_directory: "~/InfoBase"
+    steps:
+      - checkout:
+          path: "~/InfoBase"
+
+      - top_level_install
+      - form_backend_install
 
       - restore_cache:
           keys:
@@ -90,49 +158,15 @@ jobs:
       - image: eaadtbs/ib-ci-build:3.0
         <<: *dockerhub_auth
     working_directory: "~/InfoBase"
-    environment:
-      CYPRESS_CACHE_FOLDER: "~/InfoBase/client/.cache/Cypress"
     resource_class: medium
     steps:
       - checkout:
           path: "~/InfoBase"
       - run: ./scripts/ci_scripts/create_envs.sh
 
-      - restore_cache:
-          keys:
-            - top-level-dependencies-{{ checksum "package-lock.json" }}-v4
-      - run:
-          command: |
-            [ -e "node_modules" ] ||  npm ci
-      - save_cache:
-          key: top-level-dependencies-{{ checksum "package-lock.json" }}-v4
-          paths:
-            - node_modules
-
-      # need to bust the client package cache on patch changes in addition to package-lock changes
-      - run: cksum ./client/patches/* > client-patch-checksums
-      - restore_cache:
-          keys:
-            - client-dependencies-{{ checksum "client/package-lock.json" }}-{{ checksum "client-patch-checksums" }}-v2
-      - run:
-          command: |
-            [ -e "client/node_modules" ] || (cd client && npm ci)
-      - save_cache:
-          key: client-dependencies-{{ checksum "client/package-lock.json" }}-{{ checksum "client-patch-checksums" }}-v2
-          paths:
-            - client/node_modules
-            - client/.cache/Cypress
-
-      - restore_cache:
-          keys:
-            - server-dependencies-{{ checksum "server/package-lock.json" }}-v2
-      - run:
-          command: |
-            [ -e "server/node_modules" ] || (cd server && npm ci)
-      - save_cache:
-          key: server-dependencies-{{ checksum "server/package-lock.json" }}-v2
-          paths:
-            - server/node_modules
+      - top_level_install
+      - client_install
+      - server_install
 
       # transpiling the server slightly out of place for this job, not needed till the server deploy step, but
       # the deploy job image isn't guaranteed to have the necessary environment for this
@@ -272,8 +306,6 @@ jobs:
       - image: eaadtbs/ib-ci-cypress:4.0
         <<: *dockerhub_auth
     working_directory: "~/InfoBase"
-    environment:
-      CYPRESS_CACHE_FOLDER: "~/InfoBase/client/.cache/Cypress"
     parameters:
       batch-count:
         type: integer
@@ -380,6 +412,10 @@ jobs:
       - run: if [[ $CIRCLE_BRANCH = master ]]; then ./scripts/ci_scripts/store_bundle_stats.sh; fi
 
 workflows:
+  static_analysis:
+    jobs:
+      - static_analysis
+
   test_form_backend:
     jobs:
       - test_form_backend

.eslintignore

@@ -0,0 +1,7 @@
+*/.coverage
+*/.cache
+*/transpiled_build
+client/build
+client/build_prod
+client/src/**/*.scss.d.ts
+client/scripts/typescript_progress/output

.eslintrc.json

@@ -8,7 +8,10 @@
     "plugin:import/errors"
   ],
   "rules": {
-    "no-unused-vars": ["warn", { "args": "none" }],
+    "no-unused-vars": [
+      "warn",
+      { "ignoreRestSiblings": true, "argsIgnorePattern": "^_.+" }
+    ],
     "no-use-before-define": ["error", { "functions": true, "classes": true }],
     "no-throw-literal": "error",
     "lodash/no-double-unwrap": ["error"],

.gitignore

@@ -20,4 +20,5 @@ npm-debug*
 node_modules/
 .local_mongo
 .coverage
-.cache
+.cache
+.eslintcache

.husky/pre-push

@@ -20,8 +20,4 @@ local_branch_name=$(echo "$local_ref" | sed "s/refs\/heads\///")
 if [[ ($local_branch_name =~ ^__ || $local_branch_name =~ ^archived__ ) && $remote != "archive" ]]; then
   echo -e "\033[0;31mDouble underscore and archived branches can only be pushed to the archive (private) remote!\033[0m"
   exit 1
-fi
-
-
-# run prettier check
-npm run prettier_check .
+fi

client/.eslintrc.json

@@ -47,8 +47,11 @@
       ],
       "rules": {
         "no-prototype-builtins": "off", //common TS pattern
-        "@typescript-eslint/no-unused-vars": "off", // Lot of false positives on this rule. Better to use the exprimental
-        "@typescript-eslint/no-unused-vars-experimental": "warn",
+        "no-unused-vars": "off",
+        "@typescript-eslint/no-unused-vars": [
+          "warn",
+          { "ignoreRestSiblings": true, "argsIgnorePattern": "^_.+" }
+        ],
         "@typescript-eslint/no-redeclare": ["error"],
         "@typescript-eslint/explicit-module-boundary-types": "off", // TODO might want to turn this on later, but it will take a while to fix all the warnings
         "@typescript-eslint/ban-types": [
@@ -66,7 +69,8 @@
               }
             }
           }
-        ]
+        ],
+        "@typescript-eslint/consistent-type-imports": "error"
       }
     }
   ],

client/build_code/webpack_common.js

@@ -145,7 +145,7 @@ function get_plugins({
     }),
     new CircularDependencyPlugin({
       exclude: /node_modules/,
-      onDetected({ module: webpackModuleRecord, paths, compilation }) {
+      onDetected({ paths, compilation }) {
         /*
           Reminder: circular dependencies aren't _necessarily_ problematic. The concern is that when they _are_ the source of a bug,
           they can be a very hard to identify source. Best to avoid creating them, but at a certain point avoiding them can start

client/build_code/write_footnote_bundles.js

@@ -36,7 +36,7 @@ function populate_stores(parsed_models) {
     crso_deptcodes[id] = dept_code;
   });
 
-  _.each(programs, ({ dept_code, activity_code, crso_id }) => {
+  _.each(programs, ({ dept_code, activity_code }) => {
     const prog_id = `${dept_code}-${activity_code}`;
     program_deptcodes[prog_id] = dept_code;
   });
@@ -50,7 +50,7 @@ function populate_stores(parsed_models) {
 
   //initialize all depts and tags to have empty array of footnotes
   footnotes_by_deptcode = _.chain(depts)
-    .map(({ org_id, dept_code }) => [dept_code, []])
+    .map(({ dept_code }) => [dept_code, []])
     .fromPairs()
     .value();
 

client/cypress/integration/InfoBase/route_tests.spec.js

@@ -322,7 +322,7 @@ const run_tests_from_config = ({
         if (expect_error_boundary) {
           // To catch whatever error triggered this error boundary, otherwise this would fail even if it
           // results in the expected error boundary
-          cy.on("fail", (e, test) => {
+          cy.on("fail", (e) => {
             console.log(
               "This test was expected to fail. It did, with the following error",
               e

client/cypress/plugins/index.js

@@ -3,7 +3,7 @@
  */
 
 // eslint-disable-next-line import/no-commonjs
-module.exports = (on, config) => {
+module.exports = (on) => {
   on("task", {
     log(message) {
       console.log(message);