Skip to content

Commit

Permalink
Drop not-CI conditional on build time lint and TS checks, not a subst…
Browse files Browse the repository at this point in the history
…antial optimization, safer/more convienient to not have the extra logic on it
  • Loading branch information
Stephen-ONeil authored and Stephen Levi O'Neil committed Dec 23, 2021
1 parent 9adab48 commit 4275407
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions client/build_code/webpack_common.js
Expand Up @@ -138,14 +138,11 @@ function get_plugins({
retryDelay: 100,
maxRetries: 3,
}),
// Skip eslint and TS checks in CI. These are run outside webpack in a static analysis job, don't need to repeat in the build job
!is_ci &&
new ESLintPlugin({ extensions: ["js", "ts", "tsx"], cache: true }),
!is_ci &&
new ForkTsCheckerWebpackPlugin({
async: true,
typescript: { configFile: "tsconfig.json" },
}),
new ESLintPlugin({ extensions: ["js", "ts", "tsx"], cache: true }),
new ForkTsCheckerWebpackPlugin({
async: true,
typescript: { configFile: "tsconfig.json" },
}),
new CircularDependencyPlugin({
exclude: /node_modules/,
onDetected({ paths, compilation }) {
Expand Down

0 comments on commit 4275407

Please sign in to comment.