Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript 4.5 upgrade, loads of new linting #1351

Merged
merged 30 commits into from Dec 23, 2021
Merged

Typescript 4.5 upgrade, loads of new linting #1351

merged 30 commits into from Dec 23, 2021

Commits on Dec 22, 2021

  1. TypeScript 4.5 and Prettier 2.5 (for TS 4.5 syntax support

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    2382ac6 View commit details
    Browse the repository at this point in the history

  2. Drop deprectaed prettier rule jsxBracketSameLine

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    41e6317 View commit details
    Browse the repository at this point in the history

  3. Update eslint from 7 to 8, corresponding versions of @typescript-eslint… 

    … for TS 4.5 support
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    405187d View commit details
    Browse the repository at this point in the history

  4. Rename root package.json prettier scripts, add eslint scripts

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ddfc0d2 View commit details
    Browse the repository at this point in the history

  5. Add a prettier write call post eslint:fix, closes #1213

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    2675226 View commit details
    Browse the repository at this point in the history

  6. Change prettier:write log level to warn, default logging is overly ve… 

    …rbose
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8bbcf63 View commit details
    Browse the repository at this point in the history

  7. Use consistent, desired, configuration for no-unused-vars in both js … 

    …and ts (warn, but ignore arguments starting with an _)
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ad8eb07 View commit details
    Browse the repository at this point in the history

  8. Centralize eslint ignore rules at top level, like we have with the pr… 

    …ettier ignores. Simplifies running project-wide linting
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    682d119 View commit details
    Browse the repository at this point in the history

  9. Misc linting

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ac948b8 View commit details
    Browse the repository at this point in the history

  10. Sort out linting in root scripts, fix some lint errors there and in f… 

    …orm_backend
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8bac211 View commit details
    Browse the repository at this point in the history

  11. Lint instance of no-use-before-define in server code

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    39a8d39 View commit details
    Browse the repository at this point in the history

  12. Add stand alone repo-wide lint job to CI

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    c8400b7 View commit details
    Browse the repository at this point in the history

  13. Configure repo wide eslint command to cache

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    673c70e View commit details
    Browse the repository at this point in the history

  14. Make use of eslint caches in CI lint job

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    85f922d View commit details
    Browse the repository at this point in the history

  15. Lint no-unused-vars in form_backend and server

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    93cefc3 View commit details
    Browse the repository at this point in the history

  16. Extract CI install steps to fragments, to make sure cache keys are co… 

    …nsistently used. Add all installs to project-wide lint job to make sure necessary eslint plugins are all installed (might not be worth having this centralized lint job afterall, hmm)
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    eb0261f View commit details
    Browse the repository at this point in the history

  17. Ah, CircleCI has a "commands" syntax for reusable blocks of steps, th… 

    …at's good because whatever I was trying with yaml fragments wasn't going to work, ha
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    5fcd131 View commit details
    Browse the repository at this point in the history

  18. Set max warnings to 0 for repo wide eslint scan, mainly so CI gets th… 

    …e non 0 exit status on warnings as well as errors too
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8fb128b View commit details
    Browse the repository at this point in the history

  19. Fix rest arg error introduced by removing an unused var in the server… 

    … people popuate code
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    6ca94c3 View commit details
    Browse the repository at this point in the history

  20. Set ignoreRestSiblings: true in no-unused-vars lint rule, a bit of a … 

    …gotcha when left on the default false (and trying to fix a large numer of these quickly, ha)
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    7605694 View commit details
    Browse the repository at this point in the history

  21. Add TODO on CI lint job, consider expanding to check prettier and typ… 

    …ing as well
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    f73ee5d View commit details
    Browse the repository at this point in the history

  22. Tangent, drop some old stories modules I missed

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ec22b92 View commit details
    Browse the repository at this point in the history

  23. Lint for no-unused vars in client (everywhere outside of panels and c… 

    …omponents
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    52a65b8 View commit details
    Browse the repository at this point in the history

  24. Lint the rest of the client no-unused-vars

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    9b851dc View commit details
    Browse the repository at this point in the history

  25. Enable @typescript-eslint/consistent-type-imports, auto-fix it

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ab836e5 View commit details
    Browse the repository at this point in the history

  26. Post-rebase auto fix some consistent-type-imports instances

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    1e567ce View commit details
    Browse the repository at this point in the history

  27. Add prettier and typescript checking alongside eslint in CI static_an… 

    …alysis job, closes #1068
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    b642f09 View commit details
    Browse the repository at this point in the history

  28. Drop prettier from pre-push hook, CI's responsibility now

    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    9dd236c View commit details
    Browse the repository at this point in the history

  29. Skip lint and TS checking during CI builds, since they happen in a se… 

    …parate CI job now. Will revert this if it turns out to be an inconsiquential optimization
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8732ea2 View commit details
    Browse the repository at this point in the history

  30. Drop not-CI conditional on build time lint and TS checks, not a subst… 

    …antial optimization, safer/more convienient to not have the extra logic on it
    @Stephen-ONeil
    Stephen-ONeil committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    20d17fb View commit details
    Browse the repository at this point in the history