Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript 4.5 #1350

Closed
wants to merge 20 commits into from
Closed

Typescript 4.5 #1350

wants to merge 20 commits into from

Conversation

Stephen-ONeil
Copy link
Contributor

@Stephen-ONeil Stephen-ONeil commented Dec 22, 2021 •
edited

TODO:

  • upgrade TS (and Prettier)
    • and eslint
      • ... and fix no-unused-vars rule, tons of linting for that
      • while I'm at it, better project wide linting script, lint everywhere
      • maybe a side-job in CI to check global linting, right now only client src code is actually regularly checked by CI
  • Identify mixed JS/type imports, add type flags (see here)

@Stephen-ONeil
TypeScript 4.5 and Prettier 2.5 (for TS 4.5 syntax support
9be1598
@Stephen-ONeil
Drop deprectaed prettier rule jsxBracketSameLine
a2df49c
@Stephen-ONeil
Update eslint from 7 to 8, corresponding versions of @typescript-eslint…
996f56e 
… for TS 4.5 support
@Stephen-ONeil
Rename root package.json prettier scripts, add eslint scripts
81c6f1f
@Stephen-ONeil
Add a prettier write call post eslint:fix, closes #1213
355946b
@Stephen-ONeil
Change prettier:write log level to warn, default logging is overly ve…
ff6663f 
…rbose
@Stephen-ONeil
Use consistent, desired, configuration for no-unused-vars in both js …
1f96213 
…and ts (warn, but ignore arguments starting with an _)
@Stephen-ONeil
Centralize eslint ignore rules at top level, like we have with the pr…
db31144 
…ettier ignores. Simplifies running project-wide linting
@Stephen-ONeil
Misc linting
3d285c1
@Stephen-ONeil
Sort out linting in root scripts, fix some lint errors there and in f…
4113640 
…orm_backend
@Stephen-ONeil
Lint instance of no-use-before-define in server code
ec791eb
@Stephen-ONeil
Add stand alone repo-wide lint job to CI
c01f377
@Stephen-ONeil
Configure repo wide eslint command to cache
83c5532
@Stephen-ONeil
Make use of eslint caches in CI lint job
bacfb4c
@Stephen-ONeil
Lint no-unused-vars in form_backend and server
aa77483
@Stephen-ONeil
Extract CI install steps to fragments, to make sure cache keys are co…
ec4d093 
…nsistently used. Add all installs to project-wide lint job to make sure necessary eslint plugins are all installed (might not be worth having this centralized lint job afterall, hmm)
@Stephen-ONeil
Ah, CircleCI has a "commands" syntax for reusable blocks of steps, th…
6ae8ed4 
…at's good because whatever I was trying with yaml fragments wasn't going to work, ha
@Stephen-ONeil
Set max warnings to 0 for repo wide eslint scan, mainly so CI gets th…
02d3a2c 
…e non 0 exit status on warnings as well as errors too
@Stephen-ONeil
Fix rest arg error introduced by removing an unused var in the server…
2bc831a 
… people popuate code
@Stephen-ONeil
Set ignoreRestSiblings: true in no-unused-vars lint rule, a bit of a …
640bae6 
…gotcha when left on the default false (and trying to fix a large numer of these quickly, ha)
This was referenced Dec 22, 2021
Closed
Merged
@Stephen-ONeil
Copy link
Contributor Author

#1351

@Stephen-ONeil Stephen-ONeil deleted the typescript-4.5 branch December 22, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Stephen-ONeil