Enable @typescript-eslint/consistent-type-imports, auto-fix it

client/.eslintrc.json

@@ -69,7 +69,8 @@
               }
             }
           }
-        ]
+        ],
+        "@typescript-eslint/consistent-type-imports": "error"
       }
     }
   ],

client/src/charts/legends/LegendList.tsx

@@ -6,7 +6,7 @@ import { CheckBox } from "src/components/CheckBox/CheckBox";
 
 import { is_a11y_mode } from "src/core/injected_build_constants";
 
-import { ComponentProps } from "src/types/util_types.d";
+import type { ComponentProps } from "src/types/util_types.d";
 
 import type { LegendItemType } from "./LegendItemType";
 

client/src/charts/legends/StandardLegend.tsx

@@ -2,7 +2,8 @@ import React from "react";
 
 import { LegendContainer } from "./LegendContainer";
 
-import { LegendList, LegendListProps } from "./LegendList";
+import type { LegendListProps } from "./LegendList";
+import { LegendList } from "./LegendList";
 
 import "./StandardLegend.scss";
 

client/src/charts/legends/TabularLegend.tsx

@@ -3,7 +3,7 @@ import React from "react";
 
 import { CheckBox } from "src/components/index";
 
-import { StaticLegendItemType } from "./LegendItemType";
+import type { StaticLegendItemType } from "./LegendItemType";
 import "./TabularLegend.scss";
 
 interface TabularLegendProps {

client/src/components/AutoHeightVirtualList.tsx

@@ -2,7 +2,7 @@ import React from "react";
 import { List } from "react-virtualized";
 import type { ListProps } from "react-virtualized";
 
-import { SafeOmit } from "src/types/util_types.d";
+import type { SafeOmit } from "src/types/util_types.d";
 
 interface AutoHeightVirtualListProps extends SafeOmit<ListProps, "height"> {
   /* eslint-disable-next-line @typescript-eslint/no-explicit-any */

client/src/components/DisplayTable/DisplayTable.tsx

@@ -11,7 +11,7 @@ import {
 } from "src/components/misc_util_components";
 import { SortDirections } from "src/components/SortDirection/SortDirection";
 
-import { FormatKey } from "src/core/format";
+import type { FormatKey } from "src/core/format";
 
 import { LegendList } from "src/charts/legends/LegendList";
 

client/src/components/DropdownMenu/DropdownMenu.tsx

@@ -1,6 +1,7 @@
 import classNames from "classnames";
 import _ from "lodash";
-import React, { BaseSyntheticEvent } from "react";
+import type { BaseSyntheticEvent } from "react";
+import React from "react";
 
 import { trivial_text_maker } from "src/models/text";
 

client/src/components/PageDetails.tsx

@@ -1,6 +1,7 @@
 import _ from "lodash";
 import React from "react";
-import { withRouter, RouteComponentProps } from "react-router";
+import type { RouteComponentProps } from "react-router";
+import { withRouter } from "react-router";
 
 import { create_text_maker } from "src/models/text";
 

client/src/components/Typeahead/Typeahead.tsx

@@ -1,19 +1,11 @@
 import classNames from "classnames";
 import _ from "lodash";
-import React, {
-  ChangeEvent,
-  KeyboardEvent,
-  Fragment,
-  ReactElement,
-} from "react";
+import type { ChangeEvent, KeyboardEvent, ReactElement } from "react";
+import React, { Fragment } from "react";
 import ReactResizeDetector from "react-resize-detector/build/withPolyfill";
 
-import {
-  AutoSizer,
-  CellMeasurer,
-  CellMeasurerCache,
-  List,
-} from "react-virtualized";
+import type { List } from "react-virtualized";
+import { AutoSizer, CellMeasurer, CellMeasurerCache } from "react-virtualized";
 
 import { AutoHeightVirtualList } from "src/components/AutoHeightVirtualList";
 import { LeafSpinner } from "src/components/LeafSpinner/LeafSpinner";

client/src/components/Typeahead/TypeaheadA11yStatus.tsx

@@ -1,9 +1,10 @@
 import _ from "lodash";
-import React, { ReactNode } from "react";
+import type { ReactNode } from "react";
+import React from "react";
 
 import { create_text_maker } from "src/models/text";
 
-import { ResultProps } from "./Typeahead";
+import type { ResultProps } from "./Typeahead";
 
 import text from "./Typeahead.yaml";
 

client/src/components/modals_and_popovers/ModalButton.tsx

@@ -1,6 +1,7 @@
 import React, { Fragment } from "react";
 
-import { withRouter, RouteComponentProps } from "react-router-dom";
+import type { RouteComponentProps } from "react-router-dom";
+import { withRouter } from "react-router-dom";
 
 import { SafeJSURL } from "src/general_utils";
 

client/src/core/reactAdapter.ts

@@ -1,5 +1,5 @@
 import _ from "lodash";
-import React from "react";
+import type React from "react";
 import ReactDOM from "react-dom";
 
 class ReactContentRenderer {

client/src/home/CardImage/CardImage.tsx

@@ -1,6 +1,7 @@
 import React from "react";
 
-import { TM, TMProps } from "src/components/TextMaker";
+import type { TMProps } from "src/components/TextMaker";
+import { TM } from "src/components/TextMaker";
 
 import "./CardImage.scss";
 

client/src/models/faq/populate_faq.ts

@@ -1,9 +1,7 @@
 import _ from "lodash";
 
-import {
-  ParsedCsvWithUndefineds,
-  enforced_required_fields,
-} from "src/models/utils/populate_utils";
+import type { ParsedCsvWithUndefineds } from "src/models/utils/populate_utils";
+import { enforced_required_fields } from "src/models/utils/populate_utils";
 
 import { lang } from "src/core/injected_build_constants";
 

client/src/models/footnotes/dynamic_footnotes.ts

@@ -8,7 +8,7 @@ import {
   fiscal_year_to_year,
 } from "src/models/years";
 
-import { FootNoteDef } from "./footnotes";
+import type { FootNoteDef } from "./footnotes";
 
 import text from "./dynamic_footnotes.yaml";
 

client/src/models/footnotes/populate_footnotes.ts

@@ -1,7 +1,8 @@
 import { csvParse } from "d3-dsv";
 import _ from "lodash";
 
-import { Dept, CRSO, Program, SubjectInstance } from "src/models/subjects";
+import type { SubjectInstance } from "src/models/subjects";
+import { Dept, CRSO, Program } from "src/models/subjects";
 import { run_template } from "src/models/text";
 import { fiscal_year_to_year } from "src/models/years";
 

client/src/models/glossary/populate_glossary.ts

@@ -1,9 +1,7 @@
 import _ from "lodash";
 
-import {
-  ParsedCsvWithUndefineds,
-  enforced_required_fields,
-} from "src/models/utils/populate_utils";
+import type { ParsedCsvWithUndefineds } from "src/models/utils/populate_utils";
+import { enforced_required_fields } from "src/models/utils/populate_utils";
 
 import { lang } from "src/core/injected_build_constants";
 

client/src/models/subjects/BaseSubjectFactory.ts

@@ -1,6 +1,6 @@
 import _ from "lodash";
 
-import { Store } from "src/models/utils/make_store";
+import type { Store } from "src/models/utils/make_store";
 
 export const BaseSubjectFactory = <SubjectDef extends { id: string }>(
   subject_type: string,

client/src/models/subjects/populate_subjects.ts

@@ -1,9 +1,7 @@
 import _ from "lodash";
 
-import {
-  ParsedCsvWithUndefineds,
-  enforced_required_fields,
-} from "src/models/utils/populate_utils";
+import type { ParsedCsvWithUndefineds } from "src/models/utils/populate_utils";
+import { enforced_required_fields } from "src/models/utils/populate_utils";
 
 import { lang } from "src/core/injected_build_constants";