Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a CI step that checks that webpack output is clean #1068

Closed
AlexCLeduc opened this issue May 7, 2021 · 1 comment · Fixed by #1351
Closed

Have a CI step that checks that webpack output is clean #1068

AlexCLeduc opened this issue May 7, 2021 · 1 comment · Fixed by #1351

Comments

@AlexCLeduc
Copy link
Contributor

We should have a check that the webpack output has no errors or warnings. This is going to ensure that static typing and linting both pass. It's also going to speed up PR reviews.

This should not hold back dev-link creation or other CI steps

@Stephen-ONeil
Copy link
Contributor

Stephen-ONeil commented Dec 22, 2021

Linting portion is covered by a distinct lint job after #1351, maybe type checking could be handled similarly. Maybe speed up CI builds by disabling lint and type checking after that (if it's worth while, might be relatively minor since linting during builds at least s cached).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants