Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with flake8 v6 #110

Closed
matthiasdiener opened this issue Nov 23, 2022 · 1 comment · Fixed by #111
Closed

Incompatibility with flake8 v6 #110

matthiasdiener opened this issue Nov 23, 2022 · 1 comment · Fixed by #111

Comments

@matthiasdiener
Copy link 

$ pip freeze |grep flake
flake8==6.0.0
flake8-quotes==3.3.1
pyflakes==3.0.0

$ flake8
Traceback (most recent call last):
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/bin/flake8", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/site-packages/flake8/main/cli.py", line 23, in main
    app.run(argv)
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/site-packages/flake8/main/application.py", line 198, in run
    self._run(argv)
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/site-packages/flake8/main/application.py", line 186, in _run
    self.initialize(argv)
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/site-packages/flake8/main/application.py", line 165, in initialize
    self.plugins, self.options = parse_args(argv)
                                 ^^^^^^^^^^^^^^^^
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/site-packages/flake8/options/parse_args.py", line 51, in parse_args
    option_manager.register_plugins(plugins)
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/site-packages/flake8/options/manager.py", line 259, in register_plugins
    add_options(self)
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/site-packages/flake8_quotes/__init__.py", line 103, in add_options
    cls._register_opt(parser, '--quotes', action='store',
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/site-packages/flake8_quotes/__init__.py", line 93, in _register_opt
    parser.add_option(*args, **kwargs)
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/site-packages/flake8/options/manager.py", line 281, in add_option
    self._current_group.add_argument(*option_args, **option_kwargs)
  File "/Users/mdiener/Work/emirge/miniforge3/envs/ceesd/lib/python3.11/argparse.py", line 1448, in add_argument
    raise ValueError('%r is not callable' % (type_func,))
ValueError: 'choice' is not callable
@matthiasdiener matthiasdiener mentioned this issue Nov 23, 2022
Merged
matthiasdiener added a commit to illinois-ceesd/emirge that referenced this issue Nov 24, 2022
@matthiasdiener
limit flake8 version due to flake8-quotes incompatibility
909c408 
See zheller/flake8-quotes#110
@matthiasdiener matthiasdiener mentioned this issue Nov 24, 2022
Merged
tchaikov added a commit to tchaikov/ceph that referenced this issue Nov 24, 2022
@tchaikov
cephadm: pin fake8 to 5.0.4
7b52593 
to workaround zheller/flake8-quotes#110

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue Nov 24, 2022
@tchaikov
cephadm: pin flake8 to 5.0.4
eda0355 
to workaround zheller/flake8-quotes#110
flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
@tchaikov tchaikov mentioned this issue Nov 24, 2022
Merged
14 tasks
tchaikov added a commit to tchaikov/ceph that referenced this issue Nov 24, 2022
@tchaikov
cephadm: pin flake8 to 5.0.4
ecb3fb1 
to workaround zheller/flake8-quotes#110
flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.

Fixes: https://tracker.ceph.com/issues/58069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
@alexfikl alexfikl mentioned this issue Nov 24, 2022
Merged
@JJMC89 JJMC89 mentioned this issue Nov 24, 2022
Closed
@Avasam
Copy link

Avasam commented Nov 24, 2022 •
edited

Not just "potential". It is incompatible. Small migration guide: PyCQA/flake8#1739

@matthiasdiener matthiasdiener changed the title Potential incompatibility with flake8 v6 Incompatibility with flake8 v6 Nov 24, 2022
ramosbugs added a commit to unflakable/unflakable-python that referenced this issue Nov 24, 2022
@ramosbugs
Pin flake8 to 5.0.4
c88d74e 
The new 6.0.0 release is incompatible with the latest version of
flake8-quotes (see zheller/flake8-quotes#110).
idryomov pushed a commit to idryomov/ceph that referenced this issue Nov 25, 2022
@tchaikov @idryomov
cephadm: pin flake8 to 5.0.4
4deecf5 
to workaround zheller/flake8-quotes#110
flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.

Fixes: https://tracker.ceph.com/issues/58069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit ecb3fb1)
idryomov pushed a commit to idryomov/ceph that referenced this issue Nov 25, 2022
@tchaikov @idryomov
cephadm: pin flake8 to 5.0.4
532a978 
to workaround zheller/flake8-quotes#110
flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.

Fixes: https://tracker.ceph.com/issues/58069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit ecb3fb1)
@vytas7 vytas7 mentioned this issue Nov 27, 2022
Merged
inducer added a commit to pyrometheus/pyrometheus that referenced this issue Nov 27, 2022
@inducer
Restrict flake8 version for compatibility with flake8-quotes
e7c4aae 
zheller/flake8-quotes#110
@inducer inducer mentioned this issue Nov 27, 2022
Merged
inducer added a commit to pyrometheus/pyrometheus that referenced this issue Nov 27, 2022
@inducer
Restrict flake8 version for compatibility with flake8-quotes
ce605b3 
zheller/flake8-quotes#110
@mvandenburgh mvandenburgh mentioned this issue Nov 28, 2022
Merged
matthiasdiener added a commit to illinois-ceesd/emirge that referenced this issue Nov 28, 2022
@matthiasdiener
limit flake8 version due to flake8-quotes incompatibility (#156)
b88a6ca 
See zheller/flake8-quotes#110
mdevaev added a commit to pikvm/kvmd that referenced this issue Nov 29, 2022
@mdevaev
pinned flake8==5.0.4 due zheller/flake8-quotes#110
35fb7e9
mdevaev added a commit to pikvm/ustreamer that referenced this issue Nov 29, 2022
@mdevaev
pinned flake8==5.0.4 due zheller/flake8-quotes#110
aba8396
@eviljeff eviljeff mentioned this issue Nov 29, 2022
Merged
@matthiasdiener matthiasdiener mentioned this issue Nov 29, 2022
Merged
8 tasks
matthiasdiener added a commit to illinois-ceesd/mirgecom that referenced this issue Nov 29, 2022
@matthiasdiener
Restrict flake8 version (#803)
3b3693d 
Due to zheller/flake8-quotes#110
@n2ygk n2ygk mentioned this issue Nov 30, 2022
Merged
5 tasks
@DimitriPapadopoulos DimitriPapadopoulos mentioned this issue Dec 1, 2022
Closed
@maratori maratori mentioned this issue Dec 1, 2022
Merged
sukritkalra added a commit to erdos-project/erdos-scheduling-simulator that referenced this issue Dec 2, 2022
@sukritkalra
Removing flake8-quotes check from CI.
d32cb71 
The plugin was never updated for the newer flake8 version.

See zheller/flake8-quotes#110
dkliban added a commit to dkliban/plugin_template that referenced this issue Dec 5, 2022
@dkliban
Don't install flake8-quotes
376ed9f 
It's not compatible with flake8 6.0.0

zheller/flake8-quotes#110

[noissue]
dkliban added a commit to pulp/plugin_template that referenced this issue Dec 5, 2022
@dkliban
Don't install flake8-quotes
287fc4d 
It's not compatible with flake8 6.0.0

zheller/flake8-quotes#110

[noissue]
@CagtayFabry CagtayFabry mentioned this issue Dec 6, 2022
Merged
pbelskiy added a commit to pbelskiy/aiojenkins that referenced this issue Dec 6, 2022
@pbelskiy
fix flake8-quotes
09209c9 
zheller/flake8-quotes#110
@RNKuhns RNKuhns mentioned this issue Dec 7, 2022
Merged
@cjmayo cjmayo mentioned this issue Dec 7, 2022
Merged
@matthiasdiener matthiasdiener mentioned this issue Jan 17, 2023
Merged
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this issue Feb 15, 2023
@tchaikov @aaSharma14
cephadm: pin flake8 to 5.0.4
99a41f2 
to workaround zheller/flake8-quotes#110
flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.

Fixes: https://tracker.ceph.com/issues/58069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update add_options for flake8 6.0 alexfikl/flake8-quotes
2 participants
@Avasam @matthiasdiener