Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ConvertibleToShape in make_distributed_recv #395

Merged
merged 1 commit into from Nov 23, 2022
Merged

support ConvertibleToShape in make_distributed_recv #395

merged 1 commit into from Nov 23, 2022

Conversation

matthiasdiener
Copy link
Collaborator

Should fix #394

kaushikcfd
kaushikcfd approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@kaushikcfd kaushikcfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@matthiasdiener
Copy link
Collaborator Author

The flake8 error is due to zheller/flake8-quotes#110. Should we drop flake8-quotes? It appears to be unmaintained (zheller/flake8-quotes#109).

@inducer
Copy link
Owner

inducer commented Nov 23, 2022

I'd like to keep flake8-quotes. I think it's mildly useful, at least to the extent that we care about consistent quoting. It seems that lots of people use it, so I'm confident that a new maintainer will be found. In the meantime, I'm comfortable with sticking to flake8 5.x.

inducer/ci-support@2a90a13

@inducer inducer merged commit 5745fe3 into main Nov 23, 2022
@inducer inducer deleted the shape-recv branch November 23, 2022 23:02
@inducer
Copy link
Owner

inducer commented Nov 23, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikcfd kaushikcfd kaushikcfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make_distributed_recv should accept ConvertibleToShape
3 participants
@matthiasdiener @inducer @kaushikcfd