cephadm: pin flake8 to 5.0.4 #49040
Merged
cephadm: pin flake8 to 5.0.4 #49040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cephadm
cephfs
to workaround zheller/flake8-quotes#110 flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0. Fixes: https://tracker.ceph.com/issues/58069 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
to silence the warning like ``` flake8 run-test: commands[0] | flake8 --select=F,E9 --exclude=venv,.tox ./tasks/cephfs/test_full.py:6:5: F401 'typing.Optional' imported but unused ``` since we've migrated to python3.6 and up, there is no need to be compatible with Python 2 anymore. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
wip-cephadm-flake8
branch
from
160387a
to
ef391e9
Compare
* use annotation style without comment * add noqa to import statement to prevent flake8 from complaining those which import typing modules to silence the warnings like: ``` flake8 run-test: commands[0] | flake8 --config=tox.ini alerts balancer cephadm cli_api crash devicehealth diskprediction_local hello iostat localpool nfs orchestrator prometheus selftest cephadm/schedule.py:5:1: F401 'typing.Callable' imported but unused cephadm/schedule.py:8:1: F401 'ceph.deployment.service_spec.ServiceSpec' imported but unused cephadm/tests/fixtures.py:17:1: F401 'orchestrator.OrchResult' imported but unused orchestrator/module.py:4:1: F401 'typing.Set' imported but unused orchestrator/module.py:17:1: F401 'ceph.deployment.inventory.Device' imported but unused prometheus/module.py:17:1: F401 'typing.DefaultDict' imported but unused 6 F401 'typing.Callable' imported but unused ERROR: InvocationError for command /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/.tox/flake8/bin/flake8 --config=tox.ini alerts ``` Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
wip-cephadm-flake8
branch
from
ef391e9
to
7894e7b
Compare
14 tasks
rkachach
reviewed
Nov 24, 2022
| @@ -59,7 +59,7 @@ commands = | |||
| basepython = python3 | |||
| allowlist_externals = bash | |||
| deps = | |||
| flake8 | |||
| flake8 == 5.0.4 | |||
There was a problem hiding this comment.
Out of curiosity, is there any something special about this version or because it's just the latest?
There was a problem hiding this comment.
explained in the commit message.
rkachach
approved these changes
Nov 24, 2022
14 tasks
This was referenced Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to workaround zheller/flake8-quotes#110 flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.
Signed-off-by: Kefu Chai tchaikov@gmail.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows