Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit flake8 version due to flake8-quotes incompatibility #156

Merged
merged 1 commit into from Nov 28, 2022
Merged

limit flake8 version due to flake8-quotes incompatibility #156

merged 1 commit into from Nov 28, 2022

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener marked this pull request as ready for review November 24, 2022 02:16
@matthiasdiener
Copy link
Member Author

matthiasdiener commented Nov 28, 2022 •
edited

This is ready for review. We need this PR since current installations with emirge will install a non-functional flake8.

Edit:
The CI failures are unrelated to this PR.

MTCam
MTCam approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matthiasdiener matthiasdiener merged commit b88a6ca into main Nov 28, 2022
@matthiasdiener matthiasdiener deleted the flake8-quotes branch November 28, 2022 19:31
matthiasdiener added a commit that referenced this pull request Dec 20, 2022
@matthiasdiener
Revert "limit flake8 version due to flake8-quotes incompatibility (#156…
38e06de 
…)"

This reverts commit b88a6ca.

flake8-quotes v3.3.2 is comaptible with flake8 v6.
@matthiasdiener matthiasdiener mentioned this pull request Dec 20, 2022
Merged
matthiasdiener added a commit that referenced this pull request Dec 20, 2022
@matthiasdiener
Revert "limit flake8 version due to flake8-quotes incompatibility (#156…
2525739 
…)" (#157)

* Revert "limit flake8 version due to flake8-quotes incompatibility (#156)"

This reverts commit b88a6ca.

flake8-quotes v3.3.2 is comaptible with flake8 v6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MTCam MTCam MTCam approved these changes

@inducer inducer Awaiting requested review from inducer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthiasdiener @MTCam