Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump flake8 from 5.0.4 to 6.0.0 #292

Merged
merged 1 commit into from Dec 20, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 24, 2022

Bumps flake8 from 5.0.4 to 6.0.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 24, 2022
@dependabot dependabot bot force-pushed the dependabot/pip/flake8-6.0.0 branch from 4750a93 to 1e60ce9 Compare November 25, 2022 09:43
@fscherf
Copy link
Member

fscherf commented Dec 1, 2022

@maratori: Flake8 6.0.0 seems to be incompatible with flake_quotes. Are there any alternatives?

@maratori
Copy link
Member

maratori commented Dec 1, 2022

This is a known issue zheller/flake8-quotes#110 and there is a fix already zheller/flake8-quotes#111

I see two options:

  1. Disable flake8-quotes until it's fixed and merge this PR
  2. Wait fix and after that update both flake8 and flake8-quotes

@fscherf
Copy link
Member

fscherf commented Dec 2, 2022

@maratori: Ok. I think we should wait then. Thanks! :)

@dependabot dependabot bot force-pushed the dependabot/pip/flake8-6.0.0 branch 3 times, most recently from 5232a65 to a590559 Compare December 14, 2022 06:36
@dependabot dependabot bot force-pushed the dependabot/pip/flake8-6.0.0 branch from a590559 to bfcf3c2 Compare December 19, 2022 10:44
Bumps [flake8](https://github.com/pycqa/flake8) from 5.0.4 to 6.0.0.
- [Release notes](https://github.com/pycqa/flake8/releases)
- [Commits](PyCQA/flake8@5.0.4...6.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/flake8-6.0.0 branch from bfcf3c2 to 067cf1e Compare December 20, 2022 05:23
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 65.42% // Head: 65.36% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (067cf1e) compared to base (f935c96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   65.42%   65.36%   -0.07%     
==========================================
  Files          66       66              
  Lines        4787     4787              
  Branches      928      928              
==========================================
- Hits         3132     3129       -3     
- Misses       1394     1397       +3     
  Partials      261      261              
Impacted Files Coverage Δ
lona/logging.py 34.09% <0.00%> (-2.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fscherf fscherf merged commit d3c9f4a into master Dec 20, 2022
@fscherf fscherf deleted the dependabot/pip/flake8-6.0.0 branch December 20, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants