Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin flake8 version until flake8-quotes catches up. #1227

Merged
merged 1 commit into from Dec 5, 2022

Conversation

n2ygk
Copy link
Member

@n2ygk n2ygk commented Nov 30, 2022

Fixes #1226

Description of the Change

flake8 6.0.0 made a breaking change that flake8-quotes has not caught up to yet. See zheller/flake8-quotes#110
temporarily pin the version.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from a team November 30, 2022 21:17
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #1227 (8f8b294) into master (a2b7bee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1227   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          26       26           
  Lines        1317     1317           
=======================================
  Hits         1267     1267           
  Misses         50       50           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dopry dopry merged commit c4fe071 into jazzband:master Dec 5, 2022
@dopry
Copy link
Contributor

dopry commented Dec 5, 2022

@n2ygk Thanks for catching that. Should we open an issue to back it out?

@n2ygk n2ygk deleted the issue1226_flake8 branch December 5, 2022 16:37
@n2ygk
Copy link
Member Author

n2ygk commented Dec 5, 2022

@n2ygk Thanks for catching that. Should we open an issue to back it out?

Yes that's a good idea

@n2ygk n2ygk added this to the Future milestone Feb 12, 2023
@n2ygk n2ygk modified the milestones: Future, 2.3.0 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest flake8 breaks tox test
2 participants