Add Python 3.11 to GHA #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same problem, but looks like flake8-quotes here. Maybe pinning flake8 is the best option. Line 13 in 2784660 |
|
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
lurch
reviewed
Dec 8, 2022
Comment on lines
+3
to
5
| # $ make install PYTHON=python3.7 | ||
|
|
||
| PYTHON = python3 |
There was a problem hiding this comment.
Should this be PYTHON ?= python3 ?
https://www.gnu.org/software/make/manual/html_node/Setting.html
There was a problem hiding this comment.
Linked doc says:
If you’d like a variable to be set to a value only if it’s not already set, then you can use the shorthand operator ‘?=’ instead of ‘=’.
PYTHON is already set, so there's no need to use ?=
There was a problem hiding this comment.
Ahh, true. I just did a test with this Makefile:
PYTHON = python3
MYTHON ?= python3
.PHONY: test
test:
@echo "PYTHON is set to $(PYTHON)"
@echo "MYTHON is set to $(MYTHON)"which gives these results:
$ make test PYTHON=python3.8 MYTHON=python3.8
PYTHON is set to python3.8
MYTHON is set to python3.8
$ PYTHON=python3.8 MYTHON=python3.8 make test
PYTHON is set to python3
MYTHON is set to python3.8so this was just a gap in my understanding of Makefile variables. Sorry!
|
Merging. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gábor Lipták gliptak@gmail.com