New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PHP 8 #1072
Support for PHP 8 #1072
Conversation
Amazing Graham, thank you. |
@davedevelopment Would you like me to prep a PR which does a 1.3 -> master branch merge for you? There will definitely be conflicts, and I should be in a good position to resolve them, with these changes fresh in my mind. :) |
@GrahamCampbell you're definitely welcome to, but I'm happy putting aside some time to do so this week and it will help me familiarise myself with the changes 馃憤 |
I'll start doing the merge in 10 minutes or so. :) |
This PR gets Mockery working properly on PHP 8. All the bells and whistles! 馃殌
EDIT: I have targetted this at 1.3 on purpose, with the aim of having a 1.3.2 release later. I'm happy to also handle merging 1.3 -> master after this PR is finished with. I'd also be happy to backport any important fixes from master to 1.3 over the next 15 months (or even encourage contributors to send to 1.3, initially).
Closes #1071. Closes #1074. Related to hamcrest/hamcrest-php#65, laravel/framework#33039, sebastianbergmann/phpunit#4325.