PHP 8 support #65
Merged
PHP 8 support #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that GitHub actions didn't run because the config is only present in my fork, but it will run along side travis once this is merged. The associated (passing) actions run from my fork can be found here: https://github.com/GrahamCampbell/hamcrest-php/actions/runs/158263545. |
|
@davedevelopment This is ready for review now. :) |
31 tasks
Ayesh
reviewed
Jul 5, 2020
|
Thank you again Graham 🙌 |
|
@davedevelopment No problem at all. :) Let me know if there's anything else outstanding that you'd like help with before you're happy to tag the next release ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
FactoryParameterfor PHP 7.1-8.0FactoryGeneratorfor newer versions of the finderFix coverage reportingRemove broken coverage reportingEDIT 1: I will use GitHub Actions to run the PHP 7+ builds, and Travis for PHP 5 and HHVM 3.18.
EDIT 2: This repo is actually not enabled on scrutinizer or coveralls, and coverage reporting has been broken for years, so I have removed it.
Related to mockery/mockery#1072, sebastianbergmann/phpunit#4325.