Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.3 Support #1065

Closed
nobuf opened this issue May 26, 2020 · 5 comments
Closed

v1.3 Support #1065

nobuf opened this issue May 26, 2020 · 5 comments

Comments

@nobuf
Copy link
Contributor

nobuf commented May 26, 2020

As 1.4 requires php7.3, some developers are probably being stuck on using 1.3.x for a while including myself. I was wondering if there's a plan on releasing 1.3.2. In particular, I'm hoping #1054 will be merged since the latest PHPStorm shows warnings on those parameters.

Thanks!
@davedevelopment
Copy link
Collaborator

I'm not against maintaining a 1.3 branch, but I'm not going to spend a lot of time on it. Merges like #1054 aren't the problem, but in the past people have requested more difficult back ports, then shied away when I asked for contributions etc.

I've just pushed a 1.3 branch, send PRs to that branch and we'll try and keep them going for a short while.

@nobuf
Copy link
Contributor Author

nobuf commented May 27, 2020

Thanks a ton! My team has been using 1.1 for some time and pretty happy with it.

@GrahamCampbell
Copy link
Contributor

Related: #1072.

@GrahamCampbell
Copy link
Contributor

I think this can be closed now. :)

@nobuf
Copy link
Contributor Author

nobuf commented Jul 9, 2020

https://github.com/mockery/mockery/releases/tag/1.3.2 👯

@nobuf nobuf closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davedevelopment @nobuf @GrahamCampbell