Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Full PHP 8.0 Support #33388

Merged
merged 3 commits into from Oct 27, 2020
Merged

[6.x] Full PHP 8.0 Support #33388

merged 3 commits into from Oct 27, 2020

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Jun 30, 2020 •
edited

Draft until most libraries have started to release PHP 8 compatible versions or at least dev builds.

Todo/Requirements:

@driesvints driesvints changed the base branch from 7.x to 6.x June 30, 2020 13:19
@GrahamCampbell GrahamCampbell changed the title Test on PHP 8 [6.x] Test on PHP 8 Jun 30, 2020
@deleugpn
Copy link
Contributor

I have started the work on opis/closure here: opis/closure#67

@GrahamCampbell GrahamCampbell force-pushed the php-8-builds branch 2 times, most recently from 5d940e5 to 35363a1 Compare July 17, 2020 23:31
driesvints
driesvints commented Jul 18, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@GrahamCampbell
Copy link
Member

Remove phpdocumentor/reflection-docblock from build

I think this will cause prefer-lowest to fail.

@driesvints
Copy link
Member Author

@GrahamCampbell doesn't seems so.

GrahamCampbell referenced this pull request in php/php-src Jul 29, 2020
@nikic
Try to fix laravel PHP 8 incompatibility
9eb7990 
[ci skip]
@GrahamCampbell
Copy link
Member

PHP 8 broke some more stuff, so Mockery is no longer working. mockery/mockery#1088 fixes that.

dkulyk
dkulyk suggested changes Aug 13, 2020
View reviewed changes
src/Illuminate/Support/Collection.php Outdated Show resolved Hide resolved
@driesvints driesvints force-pushed the php-8-builds branch 3 times, most recently from a854297 to 11e6e5b Compare August 14, 2020 09:24
@driesvints driesvints force-pushed the php-8-builds branch 2 times, most recently from 7d0286b to 99ca90d Compare August 24, 2020 12:22
@barryvdh barryvdh mentioned this pull request Aug 28, 2020
Merged
rbuzzibarrios
rbuzzibarrios reviewed Oct 3, 2020
View reviewed changes
src/Illuminate/Database/PDO/MySqlDriver.php Outdated Show resolved Hide resolved
src/Illuminate/Database/PDO/PostgresDriver.php Outdated Show resolved Hide resolved
src/Illuminate/Database/PDO/SQLiteDriver.php Outdated Show resolved Hide resolved
src/Illuminate/Database/Schema/Grammars/RenameColumn.php Outdated Show resolved Hide resolved
GrahamCampbell
GrahamCampbell previously requested changes Oct 8, 2020
View reviewed changes
src/Illuminate/Support/helpers.php Outdated Show resolved Hide resolved
@driesvints driesvints force-pushed the php-8-builds branch 2 times, most recently from ff7007a to 551d587 Compare October 9, 2020 14:16
@driesvints
Copy link
Member Author

@nikic definitely something we can consider. However, I think I'm missing something as I don't see any PHP 8 builds on the https://github.com/symfony/symfony repository?

@nikic
Copy link
Contributor

nikic commented Oct 19, 2020

@driesvints It looks like the PHP 8 build is on Travis (nightly): https://travis-ci.org/github/symfony/symfony/builds/736971898

@GrahamCampbell GrahamCampbell mentioned this pull request Oct 19, 2020
Merged
@driesvints
Copy link
Member Author

@nikic we've just partially merged this PR and are working on getting the upstream branches up to date. Releases are done tomorrow. Thanks!

@GrahamCampbell GrahamCampbell changed the title [6.x] PHP 8 Support [6.x] Full PHP 8.0 Support Oct 19, 2020
@ollieread
Copy link
Contributor

@driesvints Looks like doctrine/dbal#4347 has been merged. Just fzaninotto/Faker#2063 now but it appears that the main dev for that isn't very active with that package.

@driesvints
Copy link
Member Author

@ollieread we've contacted the maintainer to move the project to a joint organisation so we can help maintain it. Waiting for a reply now.

@ollieread
Copy link
Contributor

Excellent @driesvints , same as I said on the faker pr, should that be required id be happy to help contribute/maintain if there's need.

@GrahamCampbell GrahamCampbell marked this pull request as ready for review October 25, 2020 13:08
@driesvints driesvints marked this pull request as draft October 26, 2020 11:17
@driesvints
Copy link
Member Author

Putting this in draft again for a bit longer to see if Faker lands PHP 8 support soon.

@bram-pkg
Copy link

bram-pkg commented Oct 27, 2020 •
edited

Looks like a fork of Faker is gonna to have to be made (see fzaninotto/Faker#2063 (comment)).

@driesvints
Copy link
Member Author

@bramceulemans we saw that and already making plans on how to proceed. Stay tuned.

@viezel
Copy link

viezel commented Oct 27, 2020

@driesvints I think we need to update the Faker PR to FakerPHP/Faker#1

@driesvints driesvints marked this pull request as ready for review October 27, 2020 14:58
@taylorotwell taylorotwell merged commit 897a471 into 6.x Oct 27, 2020
@deleugpn
Copy link
Contributor

This is huge! Congratulations to the Laravel Team!

@driesvints driesvints deleted the php-8-builds branch October 27, 2020 15:12
@driesvints
Copy link
Member Author

@deleugpn thanks for your work on this as well 👍

@solano-catskillet solano-catskillet mentioned this pull request Dec 18, 2020
Closed
@Fahmy-Mohammed Fahmy-Mohammed mentioned this pull request Feb 19, 2021
Closed
@MarkVaughn MarkVaughn mentioned this pull request Feb 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkulyk dkulyk dkulyk requested changes

@GrahamCampbell GrahamCampbell GrahamCampbell left review comments

@deleugpn deleugpn deleugpn left review comments

@rbuzzibarrios rbuzzibarrios rbuzzibarrios left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet