Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: missing tests against PHP 8 #127

Closed
nunomaduro opened this issue Jul 15, 2020 · 4 comments
Closed

chore: missing tests against PHP 8 #127

nunomaduro opened this issue Jul 15, 2020 · 4 comments

Comments

@nunomaduro
Copy link
Member

Currently, the test suite is testing against PHP 7.3, and PHP 7.4. To fix this issue, you should make sure our test suite is testing also against PHP 8. So we can be prepared for PHP 8 before it gets released. 馃憤馃徎

To get started you should update

php: [7.3, 7.4]
.

Finally, and if tests are failing, you should update the source code until the tests are passing.

@nunomaduro
Copy link
Member Author

@driesvints is also trying to test the Laravel Core against PHP 8: https://github.com/laravel/framework/compare/php-8-builds. His work may help us here.

@GrahamCampbell
Copy link
Collaborator

GrahamCampbell commented Jul 15, 2020

Laravel PHP 8 is coming along well now. A big blocker was Mockery, but I fixed up all that: mockery/mockery#1072. It looks like you are facing a similar issue to mockery.

@GrahamCampbell
Copy link
Collaborator

I think you can just delete these lines entirely. They are never hit:

image

@GrahamCampbell
Copy link
Collaborator

Ish. I'll PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants