Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer.json: Allow PHP 8 #1074

Closed
wants to merge 1 commit into from
Closed

composer.json: Allow PHP 8 #1074

wants to merge 1 commit into from

Conversation

serima
Copy link

@serima serima commented Jun 29, 2020

@GrahamCampbell
Copy link
Contributor

Mockery doesn't work at all on PHP 8 yet. This PR cannot be merged yet.

@GrahamCampbell
Copy link
Contributor

GrahamCampbell commented Jun 29, 2020 •
edited

Some stuff is in progress at #1072. If you'd like to help, fixing the failing tests in that PR I linked to would be ideal.

GrahamCampbell
GrahamCampbell suggested changes Jul 5, 2020
View reviewed changes
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 This should be done on the 1.3 branch, and only when Mockery's code has been updated so it actually works, and PHP 8 is run in the CI.

@GrahamCampbell
Copy link
Contributor

I have made major progress with #1072, and it's ready for review now. 🎉

@GrahamCampbell GrahamCampbell mentioned this pull request Jul 5, 2020
Merged
@davedevelopment
Copy link
Collaborator

Closing in favour of #1072, which we'll get merged in to master

@serima serima deleted the feature/allow-php80 branch August 9, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serima @GrahamCampbell @davedevelopment