New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: move static metadata to pyproject.toml #2512
MAINT: move static metadata to pyproject.toml #2512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me. Thanks!
Given the experimental status for this feature in setuptools (and the problems we have seen in pyproj/shapely for debian packagers), let's maybe wait a few more months with this? (I think it's OK to just leave open the PR) |
I've checked this with a few debian docker images, and not surprisingly, it does not build with testing (bookworm), which uses a slightly older setuptools. But it does work with debian unstable (sid), which is encouraging. Agree to hold off a merge until I can see a clean check with debian testing. |
Just a heads up: setuptools declared defining metadata in |
That's only for the general project metadata, though, the (and anyway, whatever setuptools says about it doesn't change potential downstream packaging problems if they don't yet support such recent setuptools) |
Good news, setuptools in debian testing was recently upgraded and I've checked this with a docker image of bookworm (debian testing) with success. I can resolve the conflicts if there is appetite to merge this. |
@mwtoews great! Let's resolve the conflicts and merge then! |
ac8f04b
to
195f70b
Compare
Thanks @mwtoews! |
Hi, since 0.26, versioneer has started to support |
We could do the same with pytest but flake8 does not currently support pyproject.toml (PyCQA/flake8#234), so we won't be able to get rid of setup.cfg anyway. |
This PR is a follow-up from #2419, and moves the project metatdata from
setup.py
topyproject.toml
as described by PEP 621 and supported by setuptools >= 61. This supersedes #2424 as there are more community commitments behind maintaining project metadata inpyproject.toml
thansetup.cfg
.Details:
geopandas
andgeopandas.*
. This now findsgeopandas.io.tests
, which seems to be unintentionally excluded.install_requires
is moved topyproject.toml
asdependencies
. If a workaround is indeed required for ReadTheDocs, a modern approach should be found.setup.py
is used to support versioneer or anyone that expects to see this file. For POSIX systems, it is now an executable, and runs python3.Some of these are new or changed, so feedback or suggestions are welcome.