Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: move static metadata to setup.cfg #2424

Closed

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Apr 27, 2022

This PR is a follow-up from #2419, and moves the project metatdata from setup.py to a declarative configuration setup.cfg file.

  • New metadata are license_files and classifiers
  • Option packages is changed from explicit to find:, which adds geopandas.io.tests. Was this intentionally excluded, or was it missed?
  • Option package_data is changed from custom-generated to an equivalent list of datasets
  • Option install_requires is moved to setup.cfg. It was not clear why this would be empty for ReadTheDocs, which has these dependencies met with doc/environment.yml. However, if there is a good reason, this dynamic option can be moved back to setup.py.
  • Most of setup.py is there to support versioneer or anyone that expects to see this file.

@jorisvandenbossche
Copy link
Member

  • Option packages is changed from explicit to find:, which adds geopandas.io.tests. Was this intentionally excluded, or was it missed?

Missed by mistake I suppose

  • Option install_requires is moved to setup.cfg. It was not clear why this would be empty for ReadTheDocs, which has these dependencies met with doc/environment.yml. However, if there is a good reason, this dynamic option can be moved back to setup.py.

I think the reason for this was to avoid pip upgrading some of the dependencies from the conda environment (Readthedocs installs the checkout using pip install --upgrade .). We would need to check on RTD if this still gives problems nowadays, but we don't have RTD builds enabled on PRs ..

@jorisvandenbossche
Copy link
Member

I think the reason for this was to avoid pip upgrading some of the dependencies from the conda environment

Although this bit of code stems from a time before we used conda (#255), so it might not actually be needed anymore. I can check that on a branch in the main repo that gets temporarily enabled on RTD.

@mwtoews
Copy link
Contributor Author

mwtoews commented Jul 31, 2022

See #2512

@mwtoews mwtoews closed this Jul 31, 2022
@mwtoews mwtoews deleted the move-static-metadata-to-setup-cfg branch July 31, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants