Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a project.toml? #415

Closed
jGaboardi opened this issue Sep 18, 2022 · 1 comment · Fixed by #420
Closed

add a project.toml? #415

jGaboardi opened this issue Sep 18, 2022 · 1 comment · Fixed by #420

Comments

@jGaboardi
Copy link
Member

Should we add a project.toml file to complement our current setup.py and setup.cfg?

#!/usr/bin/env/python

@martinfleis
Copy link
Member

I honestly lost track on what is good practice here. setup.py, setup.cfg, pyproject.toml are a bit overlapping imho. So the only point of reference for me are PRs in geopandas (geopandas/geopandas#2419, geopandas/geopandas#2512, geopandas/geopandas#2424) so I'd ideally try to use the same model. I'll leave this decision to you as you seem to know more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants