Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.12 #2603

Closed
jorisvandenbossche opened this issue Oct 18, 2022 · 18 comments
Closed

Release 0.12 #2603

jorisvandenbossche opened this issue Oct 18, 2022 · 18 comments

Comments

@jorisvandenbossche
Copy link
Member

We discussed this in one of the previous community meetings to do a 0.12 release to have a GeoPandas release that works together with Shapely 2.0:

Decision: release as 0.12 with Shapely 2.0 support once 2.0b1 is released

Shapely 2.0 beta 1 was released yesterday, so maybe we should also try to release GeoPandas 0.12 shortly. This will make it much easier for people to actually test shapely 2.0 in environments where they also use geopandas (without having to install the dev version of geopandas).

We also have the following in the meeting notes:

warn during import if detect shapely 2.0 (full release, not beta) and pygeos are both installed; provide instructions on how to set env var

This is something we still need to do. #2275 kept pygeos as the default engine if installed. So for people that also install shapely 2.0b1 in an env with pygeos, they have to set an environment variable to actually test shapely.

@jorisvandenbossche
Copy link
Member Author

I am planning to do a release tomorrow. Are there specific PRs that are more or less ready you would prefer to see included?

@martinfleis
Copy link
Member

martinfleis commented Oct 21, 2022

I would include #2578, the rest can wait.

Edit: And #2605 but I guess assumed that anyway.

@martinfleis
Copy link
Member

Ah, and #2596 to get rid of matplotlib warnings.

@m-richards
Copy link
Member

Seems like CI failures on main might need to be resolved first - fiona doesn't appear to import correctly: https://github.com/geopandas/geopandas/actions/runs/3300337184/jobs/5444725744

Looking at the latest commits, we seem to have had successful builds with fiona 1.8.22 when #2575 was merged, but the latest commit seems to install it then show fiona =None in geopandas.show_versions (it's also showing gdal as None?)

@jorisvandenbossche
Copy link
Member Author

The CI issues are an upstream conda-forge pinning issue (in tiledb, which is one of the dependencies of GDAL), so not our concern directly, but of course we want green CI before releasing to verify our own tests are passing. I am trying to temporary fix with pinning to an older version in #2609

@jorisvandenbossche
Copy link
Member Author

Released! -> https://github.com/geopandas/geopandas/releases/tag/v0.12.0 (https://pypi.org/project/geopandas/0.12.0/)

Will announce if conda-forge is ready

@martinfleis
Copy link
Member

Thank you @jorisvandenbossche!

@brendan-ward
Copy link
Member

In setup.py, we have a constraint of Shapely < 2 added in #2323; this makes it somewhat more difficult to test 0.12 with Shapely 2.0b1 in tools that strictly check against this (e.g., Poetry). It is possible to get around this by using pip to uninstall Shapely 1.8.x and reinstall 2.0b1, but in the case of Poetry it tends to revert this anytime you add / remove another dependency.

Now that #2275 has been merged, do we still need this constraint?

@jorisvandenbossche
Copy link
Member Author

Oh no, I forgot about that .. Yes, that should have been removed. I suppose I will do a 0.12.1 with that then.

@jorisvandenbossche
Copy link
Member Author

v0.12.1 with the pin removed is released!

@brendan-ward
Copy link
Member

Thanks @jorisvandenbossche ! Now able to install Shapely 2.0b2 alongside GeoPandas 0.12.1 without difficulty via Poetry.

@martinfleis
Copy link
Member

Release and the follow-up patch are out. Closing.

@jorisvandenbossche
Copy link
Member Author

I was thinking to release a 0.12.2 including #2641, so we have a release fixing the known compat issues with shapely (with shapely 2.0 final being released in a few days)

Since we haven't yet merged new features since 0.12.1, we could actually just release from the main branch. However, I am a bit weary about #2512 (which could have some side effects on packaging) being included in a bug-fix release, so I could also make a branch.

@martinfleis
Copy link
Member

I was thinking to release a 0.12.2 including #2641, so we have a release fixing the known compat issues with shapely

Fine with me!

We can do a branch if you think #2512 could cause issues. I haven't seen them in a wild but that Debian packaging (or which was that) may not be as smooth. Not sure how adapted they are at this point.

@martinfleis
Copy link
Member

I'd like to get 0.12.2 out today with #2382 included. I'll leave decision on #2512 to you.

@martinfleis
Copy link
Member

0.12.2 is out.

@jorisvandenbossche
Copy link
Member Author

I can do the feedstock update (to not have to wait on the bot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants