Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Filter distutils Version warnings from pytest output #2632

Merged
merged 4 commits into from Nov 4, 2022

Conversation

rraymondgh
Copy link
Contributor

@rraymondgh rraymondgh commented Nov 2, 2022

CI logs are full of distutils Version classes are deprecated from older versions of pandas and numpy. This then means that real warnings that should be cleaned up are missed. Add to pyproject.toml to suppress DeprecationWarning from pandas and numpy that match this text.

Moved other pytest settings from setup.cfg into pyproject.toml

@jorisvandenbossche
Copy link
Member

Thanks, this is a good idea!

Practical comment: we already have some pytest configuration in setup.cfg, so let's keep it all together in that file (nowadays pytest also supports using pyproject.toml as a place to put configuration, so if putting it in another file, we should eventually move to use that one I think)

@martinfleis
Copy link
Member

nowadays pytest also supports using pyproject.toml as a place to put configuration, so if putting it in another file, we should eventually move to use that one I think

+1 to that now that #2512 is mergeable.

@rraymondgh rraymondgh changed the title CI: Create pytest.ini CI: Filter distUtils Version warning from pytest Nov 3, 2022
@rraymondgh
Copy link
Contributor Author

@jorisvandenbossche @martinfleis

+1 to that now that #2512 is mergeable.

I noted that #2512 has been merged. Have now put config into pyproject.toml and moved other pytest config from setup.cfg

@jorisvandenbossche jorisvandenbossche changed the title CI: Filter distUtils Version warning from pytest CI: Filter distutils Version warnings from pytest output Nov 4, 2022
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work, thanks!

@jorisvandenbossche jorisvandenbossche merged commit 80ac94e into geopandas:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants