New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml file #420
Conversation
Is it possible to remove setup.cfg and use only setup.py to deal with versioneer and pyproject? |
versioneer should be fine with specs in pyproject.toml instead of setup.cfg - https://github.com/python-versioneer/python-versioneer/blob/master/INSTALL.md#common-steps |
Seems this is a bit more complicated for |
@martinfleis Welp... I am not sure how to proceed with this... Should we just keep the stuff in |
Adding |
Just leave cfg as it id then. |
Codecov Report
@@ Coverage Diff @@
## main #420 +/- ##
=======================================
- Coverage 95.9% 95.9% -0.0%
=======================================
Files 13 13
Lines 2967 2957 -10
=======================================
- Hits 2846 2836 -10
Misses 121 121
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can merge this.
Resolves #415 and based on geopandas/geopandas#2419, and geopandas/geopandas#2512.
Still may need to work out the kinks later. First time trying this.