Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml file #420

Merged
merged 13 commits into from Sep 19, 2022
Merged

Add pyproject.toml file #420

merged 13 commits into from Sep 19, 2022

Conversation

jGaboardi
Copy link
Member

Resolves #415 and based on geopandas/geopandas#2419, and geopandas/geopandas#2512.

Still may need to work out the kinks later. First time trying this.

@martinfleis
Copy link
Member

Is it possible to remove setup.cfg and use only setup.py to deal with versioneer and pyproject?

@martinfleis
Copy link
Member

versioneer should be fine with specs in pyproject.toml instead of setup.cfg - https://github.com/python-versioneer/python-versioneer/blob/master/INSTALL.md#common-steps

@jGaboardi
Copy link
Member Author

Seems this is a bit more complicated for flake8 and may require another package: pyproject-flake8.

@jGaboardi
Copy link
Member Author

@martinfleis Welp... I am not sure how to proceed with this... Should we just keep the stuff in setup.cfg for now?

@jGaboardi
Copy link
Member Author

Adding "versioneer[toml]==0.26" seems to resolve the build for testing environments (see here), but not for doc building.

@martinfleis
Copy link
Member

Just leave cfg as it id then.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #420 (d5e5083) into main (81cdec4) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #420     +/-   ##
=======================================
- Coverage   95.9%   95.9%   -0.0%     
=======================================
  Files         13      13             
  Lines       2967    2957     -10     
=======================================
- Hits        2846    2836     -10     
  Misses       121     121             
Impacted Files Coverage Δ
momepy/coins.py 95.5% <0.0%> (-0.2%) ⬇️
momepy/graph.py 98.0% <0.0%> (ø)
momepy/shape.py 91.5% <0.0%> (ø)
momepy/utils.py 99.4% <0.0%> (ø)
momepy/weights.py 100.0% <0.0%> (ø)
momepy/elements.py 96.7% <0.0%> (ø)
momepy/dimension.py 98.4% <0.0%> (ø)
momepy/diversity.py 98.1% <0.0%> (ø)
momepy/intensity.py 99.0% <0.0%> (ø)
momepy/distribution.py 97.4% <0.0%> (ø)

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can merge this.

@martinfleis martinfleis merged commit d2a189f into pysal:main Sep 19, 2022
@jGaboardi jGaboardi deleted the add_project_toml branch September 19, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a project.toml?
2 participants