Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop requirement from ~> 0.88.0 to ~> 0.89.0 in /common #2420

Closed
wants to merge 1 commit into from
Closed

Update rubocop requirement from ~> 0.88.0 to ~> 0.89.0 in /common #2420

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 6, 2020 •
edited

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 0.89

New features

Bug fixes

  • #8346: Allow parentheses in single-line inheritance with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. ([@gsamokovarov][])
  • #8324: Fix crash for Layout/SpaceAroundMethodCallOperator when using Proc#call shorthand syntax. ([@fatkodima][])
  • #8332: Fix auto-correct in Style/ConditionalAssignment to preserve constant namespace. ([@biinari][])
  • #8344: Fix crash for Style/CaseLikeIf when checking against equal? and match? without a receiver. ([@fatkodima][])
  • #8323: Fix a false positive for Style/HashAsLastArrayItem when hash is not a last array item. ([@fatkodima][])
  • #8299: Fix an incorrect auto-correct for Style/RedundantCondition when using raise, rescue, or and without argument parentheses in else. ([@koic][])
  • #8335: Fix incorrect character class detection for nested or POSIX bracket character classes in Style/RedundantRegexpEscape. ([@owst][])
  • #8347: Fix an incorrect auto-correct for EnforcedStyle: hash_rockets of Style/HashSyntax with Layout/HashAlignment. ([@koic][])
  • #8375: Fix an infinite loop error for Style/EmptyMethod. ([@koic][])
  • #8385: Remove auto-correction for Lint/EnsureReturn. ([@marcandre][])
  • #8391: Mark Style/ArrayCoercion as not safe. ([@marcandre][])
  • #8406: Improve Style/AccessorGrouping's auto-correction to remove redundant blank lines. ([@koic][])
  • #8330: Fix a false positive for Style/MissingRespondToMissing when defined method with inline access modifier. ([@koic][])
  • #8422: Fix an error for Lint/SelfAssignment when using or-assignment for constant. ([@koic][])
  • #8423: Fix an error for Style/SingleArgumentDig when without a receiver. ([@koic][])
  • #8424: Fix an error for Lint/IneffectiveAccessModifier when there is begin...end before a method definition. ([@koic][])
  • #8006: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code before the if condition when considering conversation to a single-line form. ([@dsavochkin][])
  • #8283: Fix line length calculation for Style/IfUnlessModifier to correctly take into account a comment on the first line when considering conversation to a single-line form. ([@dsavochkin][])
  • #7957: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code on the last line after the end keyword when considering conversion to a single-line form. ([@dsavochkin][])
  • #8226: Fix Style/IfUnlessModifier to add parentheses when converting if-end condition inside an array or a hash to a single-line form. ([@dsavochkin][])
  • #8443: Fix an incorrect auto-correct for Style/StructInheritance when there is a comment before class declaration. ([@koic][])
  • #8444: Fix an error for Layout/FirstMethodArgumentLineBreak when using kwargs in super. ([@koic][])

Changes

  • #8376: Style/MethodMissingSuper cop is removed in favor of new Lint/MissingSuper cop. ([@fatkodima][])
Changelog

Sourced from rubocop's changelog.

0.89.0 (2020-08-05)

New features

Bug fixes

  • #8346: Allow parentheses in single-line inheritance with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. ([@gsamokovarov][])
  • #8324: Fix crash for Layout/SpaceAroundMethodCallOperator when using Proc#call shorthand syntax. ([@fatkodima][])
  • #8332: Fix auto-correct in Style/ConditionalAssignment to preserve constant namespace. ([@biinari][])
  • #8344: Fix crash for Style/CaseLikeIf when checking against equal? and match? without a receiver. ([@fatkodima][])
  • #8323: Fix a false positive for Style/HashAsLastArrayItem when hash is not a last array item. ([@fatkodima][])
  • #8299: Fix an incorrect auto-correct for Style/RedundantCondition when using raise, rescue, or and without argument parentheses in else. ([@koic][])
  • #8335: Fix incorrect character class detection for nested or POSIX bracket character classes in Style/RedundantRegexpEscape. ([@owst][])
  • #8347: Fix an incorrect auto-correct for EnforcedStyle: hash_rockets of Style/HashSyntax with Layout/HashAlignment. ([@koic][])
  • #8375: Fix an infinite loop error for Style/EmptyMethod. ([@koic][])
  • #8385: Remove auto-correction for Lint/EnsureReturn. ([@marcandre][])
  • #8391: Mark Style/ArrayCoercion as not safe. ([@marcandre][])
  • #8406: Improve Style/AccessorGrouping's auto-correction to remove redundant blank lines. ([@koic][])
  • #8330: Fix a false positive for Style/MissingRespondToMissing when defined method with inline access modifier. ([@koic][])
  • #8422: Fix an error for Lint/SelfAssignment when using or-assignment for constant. ([@koic][])
  • #8423: Fix an error for Style/SingleArgumentDig when without a receiver. ([@koic][])
  • #8424: Fix an error for Lint/IneffectiveAccessModifier when there is begin...end before a method definition. ([@koic][])
  • #8006: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code before the if condition when considering conversation to a single-line form. ([@dsavochkin][])
  • #8283: Fix line length calculation for Style/IfUnlessModifier to correctly take into account a comment on the first line when considering conversation to a single-line form. ([@dsavochkin][])
  • #7957: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code on the last line after the end keyword when considering conversion to a single-line form. ([@dsavochkin][])
  • #8226: Fix Style/IfUnlessModifier to add parentheses when converting if-end condition inside an array or a hash to a single-line form. ([@dsavochkin][])
  • #8443: Fix an incorrect auto-correct for Style/StructInheritance when there is a comment before class declaration. ([@koic][])
  • #8444: Fix an error for Layout/FirstMethodArgumentLineBreak when using kwargs in super. ([@koic][])

Changes

Commits
  • 829c782 Cut 0.89
  • 6042aed Small Style cops perf tweaks
  • a678aba [Fixes #7755] Add Lint/OutOfRangeRefInRegexp cop (#8407)
  • 1fc1981 Fix move namespaced constant in Style/ConditionalAssignment (#8332)
  • f91df3e Add new Lint/EmptyConditionalBody cop
  • 7048b51 Enhance Gemspec/RequiredRubyVersion cop with check that `required_ruby_vers...
  • 426814e Support autocorrect for Lint/Loop cop
  • c29441f Optimize getting node tokens
  • d94c4a4 Add new Lint/BinaryOperatorWithIdenticalOperands cop
  • bf47e35 Don't mutate arguments.
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Dependabot pull requests that update Ruby code labels Aug 6, 2020
@feelepxyz
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/common/rubocop-tw-0.89.0 branch from 0fd2095 to 5c125fc Compare August 6, 2020 10:15
@feelepxyz
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/common/rubocop-tw-0.89.0 branch from 5c125fc to cf09085 Compare August 6, 2020 10:20
@feelepxyz
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/common/rubocop-tw-0.89.0 branch from cf09085 to ae97c22 Compare August 6, 2020 14:35
@feelepxyz
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/common/rubocop-tw-0.89.0 branch from ae97c22 to af1f034 Compare August 6, 2020 17:47
@feelepxyz
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/common/rubocop-tw-0.89.0 branch from af1f034 to 71f2e9f Compare August 7, 2020 12:43
@feelepxyz
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/common/rubocop-tw-0.89.0 branch from 71f2e9f to 6bcfe91 Compare August 7, 2020 14:55
@feelepxyz
Copy link
Contributor

@dependabot rebase

@dependabot
Update rubocop requirement from ~> 0.88.0 to ~> 0.89.0 in /common
3f44031 
Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.88.0...v0.89.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/common/rubocop-tw-0.89.0 branch from 6bcfe91 to 3f44031 Compare August 7, 2020 17:10
@feelepxyz
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 10, 2020

Superseded by #2441.

@dependabot dependabot bot closed this Aug 10, 2020
@dependabot dependabot bot deleted the dependabot/bundler/common/rubocop-tw-0.89.0 branch August 10, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies ruby Dependabot pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@feelepxyz