Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.90.0 to 0.91.0 #847

Closed
wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop from 0.90.0 to 0.91.0.

Release notes

Sourced from rubocop's releases.

RuboCop 0.91

New features

  • New option --cache-root and support for the RUBOCOP_CACHE_ROOT environment variable. Both can be used to override the AllCops: CacheRootDirectory config, especially in a CI setting. (@sascha-wolf)
  • #8582: Add new Layout/BeginEndAlignment cop. (@koic)
  • #8699: Add new Lint/IdentityComparison cop. (@koic)
  • Add new Lint/UselessTimes cop. (@dvandersluis)
  • #8707: Add new Lint/ConstantDefinitionInBlock cop. ([@eugeneius][])

Bug fixes

  • #8627: Fix a false positive for Lint/DuplicateRequire when same feature argument but different require method. (@koic)
  • #8674: Fix an error for Layout/EmptyLineAfterMultilineCondition when conditional is at the top level. ([@fatkodima][])
  • #8658: Fix a false positive for Style/RedundantSelfAssignment when calling coercion methods. ([@fatkodima][])
  • #8669: Fix an offense creation for Lint/EmptyFile. ([@fatkodima][])
  • #8607: Fix a false positive for Lint/UnreachableLoop when conditional branch includes continue statement preceding break statement. ([@fatkodima][])
  • #8572: Fix a false positive for Style/RedundantParentheses when parentheses are used like method argument parentheses. (@koic)
  • #8630: Fix some false positives for Style/HashTransformKeys and Style/HashTransformValues when the receiver is an array. ([@eugeneius][])
  • #8653: Fix a false positive for Layout/DefEndAlignment when using refinements and private def. (@koic)
  • #8655: Fix a false positive for Style/ClassAndModuleChildren when using cbase class name. (@koic)
  • #8654: Fix a false positive for Style/SafeNavigation when checking foo&.empty? in a conditional. (@koic)
  • #8660: Fix a false positive for Style/ClassAndModuleChildren when using cbase module name. (@koic)
  • #8664: Fix a false positive for Naming/BinaryOperatorParameterName when naming multibyte character method name. (@koic)
  • #8604: Fix a false positive for Bundler/DuplicatedGem when gem is duplciated in condition. ([@tejasbubane][])
  • #8671: Fix an error for Style/ExplicitBlockArgument when using safe navigation method call. (@koic)
  • #8681: Fix an error for Style/HashAsLastArrayItem with no_braces for empty hash. ([@fsateler][])
  • #8682: Fix a positive for Style/HashTransformKeys and Style/HashTransformValues when the each_with_object hash is used in the transformed key or value. ([@eugeneius][])
  • #8688: Mark Style/GlobalStdStream as unsafe autocorrection. ([@marcandre][])
  • #8642: Fix a false negative for Style/SpaceInsideHashLiteralBraces when a correct empty hash precedes the incorrect hash. (@dvandersluis)
  • #8683: Make naming cops work with non-ascii characters. ([@tejasbubane][])
  • #8626: Fix false negatives for Lint/UselessMethodDefinition. ([@marcandre][])
  • #8698: Fix cache to avoid encoding exception. ([@marcandre][])
  • #8704: Fix an error for Lint/AmbiguousOperator when using safe navigation operator with a unary operator. (@koic)
  • #8661: Fix an incorrect auto-correct for Style/MultilineTernaryOperator when returning a multiline ternary operator expression. (@koic)
  • #8526: Fix a false positive for Style/CaseEquality cop when the receiver is not a camel cased constant. (@koic)
  • #8673: Fix the JSON parse error when specifying --format=json and --stdin options. (@koic)

Changes

  • #8470: Do not autocorrect Style/StringConcatenation when parts of the expression are too complex. (@dvandersluis)
  • #8561: Fix Lint/UselessMethodDefinition to not register an offense when method definition includes optional arguments. ([@fatkodima][])
  • #8617: Fix Style/HashAsLastArrayItem to not register an offense when all items in an array are hashes. (@dvandersluis)
  • #8500: Add in? to AllowedMethods for Lint/SafeNavigationChain cop. ([@tejasbubane][])
  • #8629: Fix the cache being reusable in CI by using crc32 to calculate file hashes rather than mtime, which changes each CI build. (@dvandersluis)
  • #8663: Fix multiple autocorrection bugs with Style/ClassMethodsDefinitions. (@dvandersluis)
  • #8621: Add helpful Infinite Loop error message. ([@iSarCasm][])
Changelog

Sourced from rubocop's changelog.

0.91.0 (2020-09-15)

New features

  • New option --cache-root and support for the RUBOCOP_CACHE_ROOT environment variable. Both can be used to override the AllCops: CacheRootDirectory config, especially in a CI setting. ([@sascha-wolf][])
  • #8582: Add new Layout/BeginEndAlignment cop. ([@koic][])
  • #8699: Add new Lint/IdentityComparison cop. ([@koic][])
  • Add new Lint/UselessTimes cop. ([@dvandersluis][])
  • #8707: Add new Lint/ConstantDefinitionInBlock cop. ([@eugeneius][])

Bug fixes

  • #8627: Fix a false positive for Lint/DuplicateRequire when same feature argument but different require method. ([@koic][])
  • #8674: Fix an error for Layout/EmptyLineAfterMultilineCondition when conditional is at the top level. ([@fatkodima][])
  • #8658: Fix a false positive for Style/RedundantSelfAssignment when calling coercion methods. ([@fatkodima][])
  • #8669: Fix an offense creation for Lint/EmptyFile. ([@fatkodima][])
  • #8607: Fix a false positive for Lint/UnreachableLoop when conditional branch includes continue statement preceding break statement. ([@fatkodima][])
  • #8572: Fix a false positive for Style/RedundantParentheses when parentheses are used like method argument parentheses. ([@koic][])
  • #8630: Fix some false positives for Style/HashTransformKeys and Style/HashTransformValues when the receiver is an array. ([@eugeneius][])
  • #8653: Fix a false positive for Layout/DefEndAlignment when using refinements and private def. ([@koic][])
  • #8655: Fix a false positive for Style/ClassAndModuleChildren when using cbase class name. ([@koic][])
  • #8654: Fix a false positive for Style/SafeNavigation when checking foo&.empty? in a conditional. ([@koic][])
  • #8660: Fix a false positive for Style/ClassAndModuleChildren when using cbase module name. ([@koic][])
  • #8664: Fix a false positive for Naming/BinaryOperatorParameterName when naming multibyte character method name. ([@koic][])
  • #8604: Fix a false positive for Bundler/DuplicatedGem when gem is duplciated in condition. ([@tejasbubane][])
  • #8671: Fix an error for Style/ExplicitBlockArgument when using safe navigation method call. ([@koic][])
  • #8681: Fix an error for Style/HashAsLastArrayItem with no_braces for empty hash. ([@fsateler][])
  • #8682: Fix a positive for Style/HashTransformKeys and Style/HashTransformValues when the each_with_object hash is used in the transformed key or value. ([@eugeneius][])
  • #8688: Mark Style/GlobalStdStream as unsafe autocorrection. ([@marcandre][])
  • #8642: Fix a false negative for Style/SpaceInsideHashLiteralBraces when a correct empty hash precedes the incorrect hash. ([@dvandersluis][])
  • #8683: Make naming cops work with non-ascii characters. ([@tejasbubane][])
  • #8626: Fix false negatives for Lint/UselessMethodDefinition. ([@marcandre][])
  • #8698: Fix cache to avoid encoding exception. ([@marcandre][])
  • #8704: Fix an error for Lint/AmbiguousOperator when using safe navigation operator with a unary operator. ([@koic][])
  • #8661: Fix an incorrect auto-correct for Style/MultilineTernaryOperator when returning a multiline ternary operator expression. ([@koic][])
  • #8526: Fix a false positive for Style/CaseEquality cop when the receiver is not a camel cased constant. ([@koic][])
  • #8673: Fix the JSON parse error when specifying --format=json and --stdin options. ([@koic][])

Changes

  • #8470: Do not autocorrect Style/StringConcatenation when parts of the expression are too complex. ([@dvandersluis][])
  • #8561: Fix Lint/UselessMethodDefinition to not register an offense when method definition includes optional arguments. ([@fatkodima][])
  • #8617: Fix Style/HashAsLastArrayItem to not register an offense when all items in an array are hashes. ([@dvandersluis][])
  • #8500: Add in? to AllowedMethods for Lint/SafeNavigationChain cop. ([@tejasbubane][])
  • #8629: Fix the cache being reusable in CI by using crc32 to calculate file hashes rather than mtime, which changes each CI build. ([@dvandersluis][])
  • #8663: Fix multiple autocorrection bugs with Style/ClassMethodsDefinitions. ([@dvandersluis][])
  • #8621: Add helpful Infinite Loop error message. ([@iSarCasm][])
Commits
  • e0fc1c0 Cut 0.91
  • 36ea315 Fix build error
  • 80e5740 Fix an error for Style/HashAsLastArrayItem with no_braces for empty hash (#8681)
  • 295b9a6 [Fix #8663] Fix issues with Style/ClassMethodsDefinitions (#8687)
  • 0d3f5e2 [Docs] Improve example of Lint/ToJSON (#8605)
  • 3282218 [Fix #8673] Fix the JSON parse error when specifying --format=json and `--s...
  • 4b6b6c8 Fix an offense creation for Lint/EmptyFile
  • d9e04a7 [Fix #8621] Improve infinite loop message (#8701)
  • 612c176 Merge pull request #8526 from koic/fix_false_positive_for_style_case_equality
  • 252fe51 Fix a false positive for Style/CaseEquality cop
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.90.0 to 0.91.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.90.0...v0.91.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the A-deps Area: Source and library dependencies. label Sep 15, 2020
@lopopolo
Copy link
Member

The Lint/IdentityComparison cop introduced in rubocop/rubocop#8699 is buggy.

See upstream bug: rubocop/rubocop#8720.

@lopopolo
Copy link
Member

Blocked on release of rubocop/rubocop#8722

@lopopolo lopopolo added the S-blocked Status: Marked as blocked ❌ on something else such as other implementation work. label Sep 16, 2020
@dependabot-preview
Copy link
Contributor Author

Superseded by #854.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-0.91.0 branch September 24, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-deps Area: Source and library dependencies. S-blocked Status: Marked as blocked ❌ on something else such as other implementation work.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant