Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a false positive for Style/RedundantSelfAssignment when calling coercion methods #8658

Merged
merged 1 commit into from Sep 7, 2020
Merged

Fix a false positive for Style/RedundantSelfAssignment when calling coercion methods #8658

merged 1 commit into from Sep 7, 2020

Conversation

fatkodima
Copy link
Contributor

Those two returns self, not modifies its receiver in place. So that was my mistake when implementing this cop.

@fatkodima fatkodima force-pushed the fix-reduntant_self_assignment-coercion-methods branch from d9d16ce to 54963f4 Compare September 7, 2020 09:44
@marcandre
Copy link
Contributor

Thanks! (they don't always return self either...)

@marcandre marcandre merged commit 0d5d52b into rubocop:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fatkodima @marcandre