Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive Bundler/DuplicatedGem #8604

Closed
marcandre opened this issue Aug 27, 2020 · 0 comments · Fixed by #8666
Closed

False positive Bundler/DuplicatedGem #8604

marcandre opened this issue Aug 27, 2020 · 0 comments · Fixed by #8666
Labels
bug help wanted

Comments

@marcandre
Copy link
Contributor 

local = File.expand_path('../rubocop', __dir__)
if Dir.exist? local
  gem 'rubocop', path: local 
else
  gem 'rubocop', '~> 0.90.0'
end

Should not register an offense.
@tejasbubane tejasbubane mentioned this issue Sep 8, 2020
Merged
8 tasks
tejasbubane added a commit to tejasbubane/rubocop that referenced this issue Sep 8, 2020
@tejasbubane
[Fix rubocop#8604] Fix a false positive for Bundler/DuplicatedGem w…
f1a49c7 
…hen gem is duplciated in condition

Closes rubocop#8604
@koic koic closed this as completed in #8666 Sep 8, 2020
koic added a commit that referenced this issue Sep 8, 2020
@koic
Merge pull request #8666 from tejasbubane/fix-8604
6b3b322 
[Fix #8604] Fix a false positive for `Bundler/DuplicatedGem` when gem is duplicated in condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
1 participant
@marcandre