Add new Lint/IdentityComparison cop
#8699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow rubocop/ruby-style-guide#835. This PR adds new `Lint/IdentityComparison` cop. ```ruby # bad foo.object_id == bar.object_id # good foo.equal?(bar) ``` The cop prefers `equal?` over `==` when comparing `object_id`. `Object#equal?` is provided to compare objects for identity, and in contrast `Object#==` is provided for the purpose of doing value comparison.
|
Nice! I love cops that find problems in our codebase. :-) |
|
Super! |
Yeah, I will update this one. Thank you for the advice! |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Sep 12, 2020
Follow rubocop#8699 (comment) and rubocop#8606. This PR uses `RESTRICT_ON_SEND` for `Lint/IdentityComparison`.
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
Sep 12, 2020
Follow #8699 (comment) and #8606. This PR uses `RESTRICT_ON_SEND` for `Lint/IdentityComparison`.
jmkoni
pushed a commit
to standardrb/standard
that referenced
this pull request
Sep 16, 2020
…en fixed * Update Rubocop from [0.90](https://github.com/rubocop-hq/rubocop/releases/tag/v0.90.0) to [0.91](https://github.com/rubocop-hq/rubocop/releases/tag/v0.91.0), enabling: * [`Lint/UselessTimes`](rubocop/rubocop#8702) * [`Layout/BeginEndAlignment`](rubocop/rubocop#8628) * [`Lint/ConstantDefinitionInBlock`](rubocop/rubocop#8707) * [`Lint/IdentityComparison`](rubocop/rubocop#8699) re-enabling after bug fixes: * [`Bundler/DuplicatedGem`](rubocop/rubocop#8666) * [`Naming/BinaryOperatorParameterName`](rubocop/rubocop#8664)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rubocop/ruby-style-guide#835.
This PR adds new
Lint/IdentityComparisoncop.The cop prefers
equal?over==when comparingobject_id.Object#equal?is provided to compare objects for identity, and in contrastObject#==is provided for the purpose of doing value comparison.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.