Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Style/ClassAndModuleChildren #8655

Conversation

koic
Copy link
Member

@koic koic commented Sep 5, 2020

This PR fixes the following incorrect auto-correct for Style/ClassAndModuleChildren when using cbase class name.

% cat example.rb
class ::Foo
end

% bundle exec rubocop -A --only Style/ClassAndModuleChildren
(snip)

Inspecting 1 file
C

Offenses:

example.rb:1:7: C: [Corrected] Style/ClassAndModuleChildren: Use nested
module/class definitions instead of compact style.
class ::Foo
      ^^^^^

1 file inspected, 1 offense detected, 1 offense corrected

% cat example.rb
module
  class Foo
  end
end

% ruby -c example.rb
example.rb:3: syntax error, unexpected '\n', expecting '.' or &. or :: or '['

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_false_positive_for_class_and_module_children branch 3 times, most recently from e0f3f5b to dd00af3 Compare September 5, 2020 18:33
This PR fixes the following incorrect auto-correct for
`Style/ClassAndModuleChildren` when using cbase class name.

```console
% cat example.rb
class ::Foo
end

% bundle exec rubocop -A --only Style/ClassAndModuleChildren
(snip)

Inspecting 1 file
C

Offenses:

example.rb:1:7: C: [Corrected] Style/ClassAndModuleChildren: Use nested
module/class definitions instead of compact style.
class ::Foo
      ^^^^^

1 file inspected, 1 offense detected, 1 offense corrected

% cat example.rb
module
  class Foo
  end
end

% ruby -c example.rb
example.rb:3: syntax error, unexpected '\n', expecting '.' or &. or ::
or '['
```
@bbatsov bbatsov merged commit 73cbce0 into rubocop:master Sep 6, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 6, 2020

Thanks!

@koic koic deleted the fix_false_positive_for_class_and_module_children branch September 6, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants